Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force flag call-out for bypassing prompts #6506

Merged
merged 3 commits into from
Nov 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
- Fix blocking functions in the emulator when using multiple codebases (#6504).
- Add force flag call-out for bypassing prompts (#6506).
2 changes: 1 addition & 1 deletion src/commands/deploy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
export const command = new Command("deploy")
.description("deploy code and assets to your Firebase project")
.withForce(
"delete Cloud Functions missing from the current working directory without confirmation"
"delete Cloud Functions missing from the current working directory and bypass interactive prompts"
)
.option("-p, --public <path>", "override the Hosting public directory specified in firebase.json")
.option("-m, --message <message>", "an optional message describing this deploy")
Expand All @@ -60,15 +60,15 @@
.option("--except <targets>", 'deploy to all targets except specified (e.g. "database")')
.before(requireConfig)
.before((options) => {
options.filteredTargets = filterTargets(options, VALID_DEPLOY_TARGETS);

Check warning on line 63 in src/commands/deploy.ts

View workflow job for this annotation

GitHub Actions / lint (18)

Unsafe member access .filteredTargets on an `any` value

Check warning on line 63 in src/commands/deploy.ts

View workflow job for this annotation

GitHub Actions / lint (18)

Unsafe argument of type `any` assigned to a parameter of type `Options`
const permissions = options.filteredTargets.reduce((perms: string[], target: string) => {

Check warning on line 64 in src/commands/deploy.ts

View workflow job for this annotation

GitHub Actions / lint (18)

Unsafe assignment of an `any` value

Check warning on line 64 in src/commands/deploy.ts

View workflow job for this annotation

GitHub Actions / lint (18)

Unsafe member access .filteredTargets on an `any` value

Check warning on line 64 in src/commands/deploy.ts

View workflow job for this annotation

GitHub Actions / lint (18)

Unsafe call of an `any` typed value
return perms.concat(TARGET_PERMISSIONS[target]);
}, []);
return requirePermissions(options, permissions);

Check warning on line 67 in src/commands/deploy.ts

View workflow job for this annotation

GitHub Actions / lint (18)

Unsafe argument of type `any` assigned to a parameter of type `string[]`
})
.before((options) => {
if (options.filteredTargets.includes("functions")) {

Check warning on line 70 in src/commands/deploy.ts

View workflow job for this annotation

GitHub Actions / lint (18)

Unsafe member access .filteredTargets on an `any` value

Check warning on line 70 in src/commands/deploy.ts

View workflow job for this annotation

GitHub Actions / lint (18)

Unsafe call of an `any` typed value
return checkServiceAccountIam(options.project);

Check warning on line 71 in src/commands/deploy.ts

View workflow job for this annotation

GitHub Actions / lint (18)

Unsafe argument of type `any` assigned to a parameter of type `string`

Check warning on line 71 in src/commands/deploy.ts

View workflow job for this annotation

GitHub Actions / lint (18)

Unsafe member access .project on an `any` value
}
})
.before(async (options) => {
Expand Down