Limit web frameworks generated functionId to 20 chars max

CHANGELOG.md

@@ -1,3 +1,4 @@
 - Fixed an issue preventing Angular apps using ng-deploy from being emulated or deployed. (#6584)
 - Warn if a Web Framework is outside a well known version range on deploy/emulate. (#6562)
 - Use Web Framework's well known version range in `firebase init hosting`. (#6562)
+- Limit Web Framework's generated Cloud Function name to 20 characters, fixing deploys for some. (#6260)

src/frameworks/index.ts

@@ -60,7 +60,7 @@
 /**
  *
  */
 export async function discover(dir: string, warn = true) {
   const allFrameworkTypes = [
     ...new Set(Object.values(WebFrameworks).map(({ type }) => type)),
   ].sort();
@@ -87,20 +87,20 @@
 const BUILD_MEMO = new Map<string[], Promise<BuildResult | void>>();
 
 // Memoize the build based on both the dir and the environment variables
 function memoizeBuild(
   dir: string,
   build: (dir: string, target: string) => Promise<BuildResult | void>,
   deps: any[],
   target: string
 ) {
   const key = [dir, ...deps];
   for (const existingKey of BUILD_MEMO.keys()) {
     if (isDeepStrictEqual(existingKey, key)) {
       return BUILD_MEMO.get(existingKey);
     }
   }
   const value = build(dir, target);
   BUILD_MEMO.set(key, value);
   return value;
 }
 
@@ -108,7 +108,7 @@
  * Use a function to ensure the same codebase name is used here and
  * during hosting deploy.
  */
 export function generateSSRCodebaseId(site: string) {
   return `firebase-frameworks-${site}`;
 }
 
@@ -174,8 +174,9 @@
         `Hosting config for site ${site} places server-side content in region ${ssrRegion} which is not known. Valid regions are ${validRegions}`
       );
     }
     const getProjectPath = (...args: string[]) => join(projectRoot, source, ...args);
-    const functionId = `ssr${site.toLowerCase().replace(/-/g, "")}`;
+    // Combined traffic tag (19 chars) and functionId cannot exceed 46 characters.
+    const functionId = `ssr${site.toLowerCase().replace(/-/g, "").substring(0, 20)}`;
     const usesFirebaseAdminSdk = !!findDependency("firebase-admin", { cwd: getProjectPath() });
     const usesFirebaseJsSdk = !!findDependency("@firebase/app", { cwd: getProjectPath() });
     if (usesFirebaseAdminSdk) {
@@ -209,9 +210,9 @@
       if (selectedSite) {
         const { appId } = selectedSite;
         if (appId) {
           firebaseConfig = await getAppConfig(appId, AppPlatform.WEB);
           firebaseDefaults ||= {};
           firebaseDefaults.config = firebaseConfig;
         } else {
           const defaultConfig = await implicitInit(options);
           if (defaultConfig.json) {
@@ -220,7 +221,7 @@
   You can link a Web app to a Hosting site here https://console.firebase.google.com/project/${project}/settings/general/web`
             );
             firebaseDefaults ||= {};
             firebaseDefaults.config = JSON.parse(defaultConfig.json);
           } else {
             // N.B. None of us know when this can ever happen and the deploy would
             // still succeed. Maaaaybe if someone tried calling firebase serve