Limit web frameworks generated functionId to 20 chars max (#6260)

firebase · Dec 7, 2023 · 9fd1102 · 9fd1102
1 parent 31a2588
commit 9fd1102
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,4 @@
 - Fixed an issue preventing Angular apps using ng-deploy from being emulated or deployed. (#6584)
 - Warn if a Web Framework is outside a well known version range on deploy/emulate. (#6562)
 - Use Web Framework's well known version range in `firebase init hosting`. (#6562)
+- Limit Web Framework's generated Cloud Function name to 20 characters, fixing deploys for some. (#6260)
diff --git a/src/frameworks/index.ts b/src/frameworks/index.ts
@@ -175,7 +175,8 @@ export async function prepareFrameworks(
       );
     }
     const getProjectPath = (...args: string[]) => join(projectRoot, source, ...args);
-    const functionId = `ssr${site.toLowerCase().replace(/-/g, "")}`;
+    // Combined traffic tag (19 chars) and functionId cannot exceed 46 characters.
+    const functionId = `ssr${site.toLowerCase().replace(/-/g, "").substring(0, 20)}`;
     const usesFirebaseAdminSdk = !!findDependency("firebase-admin", { cwd: getProjectPath() });
     const usesFirebaseJsSdk = !!findDependency("@firebase/app", { cwd: getProjectPath() });
     if (usesFirebaseAdminSdk) {