Add systemInstruction, tools, and generationConfig to CountTokensRequest
#8827
Conversation
🦋 Changeset detectedLatest commit: 3ce689f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| */ | ||
| tools?: Tool[]; | ||
| /** | ||
| * Configuration options used for content-related requests. |
There was a problem hiding this comment.
hmmm... this description doesn't seem quite right. Let's riff on something like this?
Configuration with parameter values that control how the model generates a response.
There was a problem hiding this comment.
hmmm... this description doesn't seem quite right.
This comment was copied from the current devsite docs for GenerationConfig. Do you think this should also be updated in the GenerationConfig interface?
Configuration with parameter values that control how the model generates a response.
In a JS context, parameters specifically refer to function inputs, while generationConfig is an object with properties. I would suggest "Object containing properties that control how the model generates a response", but that seems a bit verbose to me.
There was a problem hiding this comment.
"Configuration options that control how the model generates a response." ?
There was a problem hiding this comment.
"Configuration options that control how the model generates a response." ?
+1
Size Report 1Affected ProductsNo changes between base commit (058afa2) and merge commit (9a9ed39).Test Logs |
dlarocque
force-pushed
the
dl/count-tokens
branch
from
10a6bb7 to
bdac0f0
Compare
Size Analysis Report 1Affected ProductsNo changes between base commit (058afa2) and merge commit (9a9ed39).Test Logs |
| */ | ||
| tools?: Tool[]; | ||
| /** | ||
| * Configuration options used for content-related requests. |
There was a problem hiding this comment.
"Configuration options that control how the model generates a response." ?
dlarocque
force-pushed
the
dl/count-tokens
branch
from
f7c3b41 to
3ce689f
Compare
Fixes b/397973753 (internal)
Add
systemInstruction,tools, andgenerationConfigtoCountTokensRequest.This allows users to count
totalBillableChractersfor requests that include anything beyond the content.