-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added non-null properties to database.ThenableReference #8800
Conversation
🦋 Changeset detectedLatest commit: 82c34b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
28a00af
to
8aeac68
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I have seen that error before but don't remember the cause. I can't reproduce it with the current |
Eurgh typical, setup the container again to try again from fresh and now it's fine - I think was running the same node version (20.13.1) as before too... Oh well - thanks for your help anyway! Do I need to include the |
Changeset seems fine. I will see if a RTDB SDK maintainer can review for RTDB specific changes. |
Thanks for the PR! We already cut the staging release for the current release so it might be another 3 weeks until this rolls out to NPM. |
When using
push
to add data aThenableReference
is returned, this reference can never have an undefinedkey
(orparent
) because it's never going to be the root reference.