Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade firebase-admin and google/cloud-firestore in rules-unit-testing yarn lock #8298

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Upgrade firebase-admin and google/cloud-firestore in rules-unit-testing yarn lock #8298

merged 2 commits into from
Jul 10, 2024
+11 −6

Conversation

dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Jun 5, 2024 •
edited
Loading

This change is automatically done when running yarn test in the repo. We should probably check it into the repo?

The version of google-cloud/firestore in the rules-unit-testing/functions/yarn.lock was listed as '6.6.0', when it was actually pulling '6.8.0'. This change upgrades the listed version to be the real version.

@dlarocque dlarocque requested review from DellaBitta and hsubox76 June 5, 2024 16:41
@dlarocque dlarocque requested review from avolkovi, sam-gc, yuchenshi and a team as code owners June 5, 2024 16:41
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: ae841d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 5, 2024 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (a90255a) and merge commit (544095e).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/K2wJ0P5kE6.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 5, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (a90255a) and merge commit (544095e).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zyx0CpDXlN.html

@DellaBitta
Copy link
Contributor

This looks like it changes the admin SDK version, too. If that's a dev dependency then that's fine, but if not then we should add a changeset to this PR.

@dlarocque dlarocque changed the title Upgrade google-cloud-firestore in rules-unit-testing yarn lock Upgrade google/cloud-firestore in rules-unit-testing yarn lock Jun 5, 2024
@dlarocque
Copy link
Contributor Author

This looks like it changes the admin SDK version, too. If that's a dev dependency then that's fine, but if not then we should add a changeset to this PR.

Looks like it isn't a dev dependency, so I added a changeset 👍

@dlarocque dlarocque requested review from a team as code owners June 5, 2024 18:56
@dlarocque dlarocque changed the title Upgrade google/cloud-firestore in rules-unit-testing yarn lock Upgrade firebase-admin and google/cloud-firestore in rules-unit-testing yarn lock Jun 5, 2024
@dlarocque
Copy link
Contributor Author

dlarocque commented Jun 5, 2024 •
edited
Loading

It looks like there's a ghost entry in the toc in master that's causing our doc change check to fail. #8300 should fix

Edit: this has been fixed, CI is good now

dlarocque added 2 commits June 5, 2024 15:56
@dlarocque
Upgrade google-cloud-firestore in rules-unit-testing yarn lock
a3e0b44 
The version of google-cloud-firestore in the rules-unit-testing
yarn.lock was listed as 6.6.0, when it was actually 6.8.0. This change
ugrades the listed version to be the real version.
@dlarocque
Add changeset
Loading
Loading status checks…
ae841d6
@dlarocque dlarocque force-pushed the dlarocque/yarnlock branch from 9e54504 to ae841d6 Compare June 5, 2024 20:56
@dlarocque dlarocque mentioned this pull request Jun 5, 2024
Merged
@dlarocque dlarocque merged commit d752e80 into master Jul 10, 2024
33 of 34 checks passed
@dlarocque dlarocque deleted the dlarocque/yarnlock branch July 10, 2024 17:30
@google-oss-bot google-oss-bot mentioned this pull request Jul 16, 2024
Merged
tom-andersen pushed a commit that referenced this pull request Jul 24, 2024
@dlarocque @tom-andersen
Upgrade firebase-admin and google/cloud-firestore in rules-unit-testi…
e1c321d 
…ng yarn lock (#8298)

* Upgrade google-cloud-firestore in rules-unit-testing yarn lock

The version of google-cloud-firestore in the rules-unit-testing
yarn.lock was listed as 6.6.0, when it was actually 6.8.0. This change
ugrades the listed version to be the real version.

* Add changeset
@firebase firebase locked and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76

@DellaBitta DellaBitta

@avolkovi avolkovi

@sam-gc sam-gc

@yuchenshi yuchenshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dlarocque @google-oss-bot @DellaBitta @hsubox76