Update @grpc/proto-loader dep to address protobufjs security issue #6442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 029a4b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected ProductsNo changes between base commit (39f4635) and merge commit (4f7989c).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (39f4635) and merge commit (4f7989c).Test Logs |
hsubox76
requested review from
avolkovi,
sam-gc,
yuchenshi and
lisajian
as code owners
sam-gc
approved these changes
Jul 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a security issue with versions of the
protobufjsdependency lower than 6.11.3: GHSA-g954-5hwp-pp24Firestore has a direct dependency on
protobufjswhich was already previously updated to 6.11.3. However, Firestore also has a dependency on@grpc/proto-loaderwhich had a dependency on an older version ofprotobufjs. Upgrading our@grpc/proto-loaderdependency to the most recent version updates itsprotobufjsdependency to 6.11.3 as well.Also updated
firebase-toolsandfirebase-admindeps, which have transitive dependencies onprotobufjs. This removes protobufjs 6.11.2 completely from yarn.lock.Tested by
npm packing this branch and installing it into a test project - no traces ofprotobufjs6.11.3.Had to tinker with rules-unit-testing a bit to make it work with the newer
firebase-tools.Fixes #6438