Add a Node ESM build to RUT #6360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3968d08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected ProductsNo changes between base commit (8f82660) and merge commit (183e367).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (8f82660) and merge commit (455c433).Test Logs |
yuchenshi
approved these changes
Jun 14, 2022
MarkDuckworth
approved these changes
Jun 14, 2022
|
Thanks a lot for the fix! |
|
So my proposed diagnostic/solution was right? Thanks for the credit 😉 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules-unit-testing only had a CJS build for Node. This causes it to load the CJS build of Firestore, while the user may load methods from an Node ESM build of Firestore, if their project uses ES modules. This causes there to be two copies of Firestore instances that don't match.
Tested on repro: https://github.com/MarkDuckworth/firebase-js-sdk-issues-6080 and it fixes the issue.
Fixes #6080