Fix proactive refresh logic, add some tests (#6544)

* Fix proactive refresh logic, add some tests * Changeset
firebase · Aug 19, 2022 · bea604e · bea604e
1 parent 47895fe
commit bea604e
Show file tree

Hide file tree

Showing 3 changed files with 67 additions and 3 deletions.
diff --git a/.changeset/happy-eels-confess.md b/.changeset/happy-eels-confess.md
@@ -0,0 +1,5 @@
+---
+"@firebase/auth": patch
+---
+
+Fix proactive refresh logic in Auth when RTDB/Firestore/Storage are in use
diff --git a/packages/auth/src/core/auth/auth_impl.test.ts b/packages/auth/src/core/auth/auth_impl.test.ts
@@ -306,6 +306,65 @@ describe('core/auth/auth_impl', () => {
         });
       });
 
+      context('with Proactive Refresh', () => {
+        let oldUser: UserInternal;
+
+        beforeEach(() => {
+          oldUser = testUser(auth, 'old-user-uid');
+
+          for (const u of [user, oldUser]) {
+            sinon.spy(u, '_startProactiveRefresh');
+            sinon.spy(u, '_stopProactiveRefresh');
+          }
+        });
+
+        it('null -> user: does not turn on if not enabled', async () => {
+          await auth._updateCurrentUser(null);
+          await auth._updateCurrentUser(user);
+
+          expect(user._startProactiveRefresh).not.to.have.been.called;
+        });
+
+        it('null -> user: turns on if enabled', async () => {
+          await auth._updateCurrentUser(null);
+          auth._startProactiveRefresh();
+          await auth._updateCurrentUser(user);
+
+          expect(user._startProactiveRefresh).to.have.been.called;
+        });
+
+        it('user -> user: does not turn on if not enabled', async () => {
+          await auth._updateCurrentUser(oldUser);
+          await auth._updateCurrentUser(user);
+
+          expect(user._startProactiveRefresh).not.to.have.been.called;
+        });
+
+        it('user -> user: turns on if enabled', async () => {
+          auth._startProactiveRefresh();
+          await auth._updateCurrentUser(oldUser);
+          await auth._updateCurrentUser(user);
+
+          expect(oldUser._stopProactiveRefresh).to.have.been.called;
+          expect(user._startProactiveRefresh).to.have.been.called;
+        });
+
+        it('calling start on auth triggers user to start', async () => {
+          await auth._updateCurrentUser(user);
+          auth._startProactiveRefresh();
+
+          expect(user._startProactiveRefresh).to.have.been.calledOnce;
+        });
+
+        it('calling stop stops the refresh on the current user', async () => {
+          auth._startProactiveRefresh();
+          await auth._updateCurrentUser(user);
+          auth._stopProactiveRefresh();
+
+          expect(user._stopProactiveRefresh).to.have.been.called;
+        });
+      });
+
       it('onAuthStateChange works for multiple listeners', async () => {
         const cb1 = sinon.spy();
         const cb2 = sinon.spy();

diff --git a/packages/auth/src/core/auth/auth_impl.ts b/packages/auth/src/core/auth/auth_impl.ts
@@ -581,9 +581,9 @@ export class AuthImpl implements AuthInternal, _FirebaseService {
   ): Promise<void> {
     if (this.currentUser && this.currentUser !== user) {
       this._currentUser._stopProactiveRefresh();
-      if (user && this.isProactiveRefreshEnabled) {
-        user._startProactiveRefresh();
-      }
+    }
+    if (user && this.isProactiveRefreshEnabled) {
+      user._startProactiveRefresh();
     }
 
     this.currentUser = user;