Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock activesupport because of 7.1 breaking change #11899

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Lock activesupport because of 7.1 breaking change #11899

merged 1 commit into from
Oct 5, 2023

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Oct 5, 2023

@paulb777 paulb777 enabled auto-merge (squash) October 5, 2023 20:47
andrewheard
andrewheard approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding the comment for context.

@paulb777 paulb777 merged commit a291c97 into master Oct 5, 2023
301 checks passed
@paulb777 paulb777 deleted the pb-activesupport branch October 5, 2023 20:52
@paulb777 paulb777 mentioned this pull request Oct 6, 2023
Merged
@firebase firebase locked and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@morganchen12 morganchen12 Awaiting requested review from morganchen12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly Testing Report
2 participants
@paulb777 @andrewheard