Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate QueryPurpose in spec test #10954

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Validate QueryPurpose in spec test #10954

merged 4 commits into from
Mar 16, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Mar 14, 2023 •
edited

#no-changelog
Ported from Web: firebase/firebase-js-sdk#7113
Android: firebase/firebase-android-sdk#4770

@milaGGL milaGGL self-assigned this Mar 14, 2023
@milaGGL milaGGL requested a review from dconeybe March 14, 2023 18:29
@google-oss-bot
Copy link

google-oss-bot commented Mar 14, 2023 •
edited

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.21% (b2383a9) to 88.25% (8dd05cf) by +0.04%.

    FilenameBase (b2383a9)Merge (8dd05cf)Diff
    exception.cc23.68%84.21%+60.53%
    exception_apple.mm96.55%65.52%-31.03%
    leveldb_key.cc98.82%98.14%-0.69%
    ordered_code.cc93.90%94.39%+0.49%
    task.cc93.91%94.78%+0.87%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/D1fcGye8Nl.html

dconeybe
dconeybe approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with one very minor comment about a "TODO" comment. Thanks for doing this!

Firestore/Example/Tests/SpecTests/FSTSpecTests.mm Show resolved Hide resolved
@milaGGL milaGGL merged commit 3d077ea into master Mar 16, 2023
@milaGGL milaGGL deleted the mila/validate-targetPurpose-in-spec-tests branch March 16, 2023 22:00
@firebase firebase locked and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dconeybe dconeybe dconeybe approved these changes

Assignees

@milaGGL milaGGL

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@milaGGL @google-oss-bot @dconeybe