Add Detector for XXE in XML Validator #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements a new Detector for XML External Entity processing with
javax.xml.validation.Valdatoras described in issue #395. Implementing a Detector for XML External Entity processing withjavax.xml.validation.SchemaFactoryfor the same issue can be handled separately.The implementation follows the pattern of other XXE Detectors and supports solutions that enable Secure Processing or disable access to both External Document Type Declarations and External Schemas.
The documentation provides examples of both external entity references and external schema locations, as well as examples of vulnerable code and potential solutions.