Code Quality: Use RichCommands in home and sidebar

[0x5bfa]

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

• Related Code Quality: Use RichCommand for widget items #14760

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

1. Open Files app
2. Right click widget item (use those three commands)
3. Right click sidebar item (again)

Confirmed it's working

[yaira2]

Are the sidebar contexts hidden from the command palette and actions page?

[0x5bfa]

Ouch, I forgot to do that, will do.

[0x5bfa]

Done

[hishitetsu]

• The app always crashes when closing a tab.

2024-06-01 23:41:04.2830|Error|System.NullReferenceException: Object reference not set to an instance of an object.
   at Files.App.Views.PaneHolderPage.Dispose()
   at Files.App.UserControls.TabBar.TabBarItem.Dispose()
   at Files.App.UserControls.TabBar.TabBarItem.Unload()
   at Files.App.UserControls.TabBar.BaseTabBar.CloseTab(TabBarItem tabItem)
   at Files.App.UserControls.TabBar.BaseTabBar.TabView_TabCloseRequested(TabView sender, TabViewTabCloseRequestedEventArgs args)
   at WinRT._EventSource_global__Windows_Foundation_TypedEventHandler_global__Microsoft_UI_Xaml_Controls_TabView__global__Microsoft_UI_Xaml_Controls_TabViewTabCloseRequestedEventArgs_.EventState.<GetEventInvoke>b__1_0(TabView sender, TabViewTabCloseRequestedEventArgs args)
   at ABI.Windows.Foundation.TypedEventHandler`2.Do_Abi_Invoke[TSenderAbi,TResultAbi](Void* thisPtr, TSenderAbi sender, TResultAbi args)

• OpenInNewPaneFromSidebarAction always causes a crash.

2024-06-01 23:39:49.4049|Error|System.NullReferenceException: Object reference not set to an instance of an object.
   at Files.App.Actions.OpenInNewPaneFromSidebarAction.ExecuteAsync(Object parameter)
   at Files.App.Data.Commands.ActionCommand.Execute(Object parameter)
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)
   at Microsoft.UI.Dispatching.DispatcherQueueSynchronizationContext.<>c__DisplayClass2_0.<Post>b__0()

• Actions with IsAccessibleGlobally set to false should be excluded from custom hotkeys.
  

[hishitetsu]

Still occasionally crashes when opening tabs or panes from the home page.

2024-06-02 22:28:52.3068|Error|System.NullReferenceException: Object reference not set to an instance of an object.
   at Files.App.Actions.OpenInNewPaneFromHomeAction.ExecuteAsync(Object parameter)
   at Files.App.Data.Commands.ActionCommand.Execute(Object parameter)
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)
   at Microsoft.UI.Dispatching.DispatcherQueueSynchronizationContext.<>c__DisplayClass2_0.<Post>b__0()

2024-06-02 22:30:06.9409|Error|System.NullReferenceException: Object reference not set to an instance of an object.
   at Files.App.Actions.OpenInNewTabFromHomeAction.ExecuteAsync(Object parameter)
   at Files.App.Data.Commands.ActionCommand.Execute(Object parameter)
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)
   at Microsoft.UI.Dispatching.DispatcherQueueSynchronizationContext.<>c__DisplayClass2_0.<Post>b__0()

[0x5bfa]

Did you click Open command immediately after context menu opened?

[hishitetsu]

Did you click Open command immediately after context menu opened?

No, I didn't. I don't know under what conditions this occurs, but I don't think the null check is a fundamental solution since it occurred during normal operation.

[yaira2]

This should help unblock #4262

[yaira2]

What's the latest on this PR?

[hishitetsu]

Still occasionally crashes when opening tabs or panes from the home page.

This problem hasn't been resolved. @0x5bfa put a null check, but I think the action may still not work just not crash.
#15329 (comment)

[hishitetsu]

I tracked down the cause of crashes. If you right-click on one item and then right-click on another item without closing the first context menu, the item set in the opening event will be overwritten to null in the first context menu's closed event.
I don't think we should clear HomePageContext.RightClickedItem when the context menu has been closed because it may make HomePageContext.RightClickedItem null during the action.

[hishitetsu]

The same problem exists in the sidebar, although it doesn't crash.

[0x5bfa]

Ah then this is fixed in widget?

[hishitetsu]

Ah then this is fixed in widget?

Yes👍

[0x5bfa]

Nice! Thank you for checking.

[hishitetsu]

I found another issue. When I right-click a sidebar section title (Pinned, Drivers, etc.), Open in commands appear and the home page will open when executing them. The commands should not appear.

[0x5bfa]

Fixed

[hishitetsu]

LGTM

[yaira2]

@0x5bfa can you resolve the merge conflicts?