Fix 1.78 lints #2491
Merged
Fix 1.78 lints #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
|
The changes in the LLM host component were because it was giving "never constructed" lints on the |
fibonacci1729
approved these changes
May 7, 2024
|
It looks like the |
|
@lann I'd be delighted to revert it if there is consensus to do so. I'm not a fan of the readability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried installing 1.78 to see if it fixed #2424 and no it doesn't but hoo boy is it mad about the precious
clone()s.It also started giving deprecation warnings on
./cargo/config, so I renamed that too. The warning says the new name works from Cargo 1.38 so should not be a problem for us on 1.74.