Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: very good analysis #154

Closed

Conversation

jamesblasco
Copy link
Contributor

Regarding very_good_analysis, I disabled two rules that were used extensively in the library

  • library_private_types_in_public_api. A private method is returned in two functions
    _Verify get verify => _makeVerify(false);
  • parameter_assignments. I not sure how to rename the inner variables vs the method parameters
    Expectation<dynamic> _exceptionResponse(
    void Function(Invocation)? exceptionBuilder,
    ) {
    exceptionBuilder ??= (invocation) {
    throw MissingStubError(invocation);
    };
    return Expectation<dynamic>.allInvocations(exceptionBuilder);

Status

IN DEVELOPMENT

Breaking Changes

NO

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel
Copy link
Owner

@jamesblasco just merged #150 if you have some time are you able to resolve the merge conflicts? Thanks!

@felangel
Copy link
Owner

Closing since this was addressed by #203

@felangel felangel closed this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants