Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mocktail_image_network): pass onDone callback when listening to stream #120

Merged
merged 1 commit into from Mar 9, 2022
Merged

fix(mocktail_image_network): pass onDone callback when listening to stream #120

merged 1 commit into from Mar 9, 2022

Conversation

Kirpal
Copy link
Contributor

@Kirpal Kirpal commented Mar 9, 2022

Status

READY

Breaking Changes

NO

Description

I ran into an issue using precacheImage, which would never complete when wrapped with mockNetworkImages. I fixed it by passing through the onDone callback when listening to the image stream.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@Kirpal Kirpal requested a review from felangel as a code owner March 9, 2022 14:01
felangel
felangel approved these changes Mar 9, 2022
View reviewed changes
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀
Thanks for the contribution! 💙

@felangel felangel added the bug Something isn't working label Mar 9, 2022
@felangel felangel merged commit 58c6aa3 into felangel:main Mar 9, 2022
@Kirpal Kirpal deleted the fix/on-done branch March 9, 2022 14:46
@kturney kturney mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

Assignees

@Kirpal Kirpal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kirpal @felangel