Add delete records admin client api #531
Conversation
|
Sure, I'll add a test. |
|
@benesch Added tests for the delete records api. |
|
@benesch Can you please take a look at the PR. Thanks. |
tests/test_admin.rs
Outdated
| let res = admin_client.delete_records(&offsets, &opts).await; | ||
| assert_eq!(res, Err(KafkaError::AdminOp(RDKafkaErrorCode::NoEnt))); | ||
| } | ||
| } |
There was a problem hiding this comment.
This is too much code to duplicate to test this feature. Could you instead work the delete_records bit into test_topics?
There was a problem hiding this comment.
@benesch any update on the review?
There was a problem hiding this comment.
Hi @benesch is there anything I can do to help merge this?
|
Hi! Any plans to merge it? |
|
Hey @davidblewett! Just wanted to give you a heads-up that there were some updates to address @benesch's initial feedback on the PR. Totally understand that life gets busy and everyone has their own commitments. If you find a moment to review and potentially merge it, it would be a fantastic help. Thanks a ton! |
This PR adds bindings to the delete records c API.