Fix multi-parameter println spacing #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fmt.Println` will add spaces between elements when there is multiple parameters sent. When wrapping the colors parameters were combined using `fmt.Sprint(a...)` - which does not space out parameters. Use `fmt.Sprintln` to combine parameters. Fixes fatih#218
|
Thank you @klauspost for the fix. How important is a release for you? I was planning to wait a few weeks before releasing a new version. |
|
@fatih Not very, as it is cosmetic. I can always pin the master commit. Feel free to keep it for the RGB release. |
|
Got it, thank you again. Feel free to ping me If I forgot the release. |
|
@fatih Gentle ping. |
|
@klauspost, thanks for the ping. Released a new version https://github.com/fatih/color/releases/tag/v1.17.0 |
renovate bot
added a commit
to anoriqq/qpm
that referenced
this pull request
May 13, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/fatih/color](https://togithub.com/fatih/color) | `v1.16.0` -> `v1.17.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fatih/color (github.com/fatih/color)</summary> ### [`v1.17.0`](https://togithub.com/fatih/color/releases/tag/v1.17.0) [Compare Source](https://togithub.com/fatih/color/compare/v1.16.0...v1.17.0) #### What's Changed - Fix multi-parameter println spacing by [@​klauspost](https://togithub.com/klauspost) in [fatih/color#228 - ci: update Go and Staticcheck versions by [@​fatih](https://togithub.com/fatih) in [fatih/color#222 - Bump golang.org/x/sys from 0.14.0 to 0.17.0 by [@​dependabot](https://togithub.com/dependabot) in [fatih/color#221 - Bump actions/setup-go from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [fatih/color#217 - Bump golang.org/x/sys from 0.17.0 to 0.18.0 by [@​dependabot](https://togithub.com/dependabot) in [fatih/color#224 #### New Contributors - [@​klauspost](https://togithub.com/klauspost) made their first contribution in [fatih/color#228 **Full Changelog**: fatih/color@v1.16.0...v1.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/anoriqq/qpm). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
jooola
pushed a commit
to hetznercloud/cli
that referenced
this pull request
May 13, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/fatih/color](https://togithub.com/fatih/color) | `v1.16.0` -> `v1.17.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fatih/color (github.com/fatih/color)</summary> ### [`v1.17.0`](https://togithub.com/fatih/color/releases/tag/v1.17.0) [Compare Source](https://togithub.com/fatih/color/compare/v1.16.0...v1.17.0) #### What's Changed - Fix multi-parameter println spacing by [@​klauspost](https://togithub.com/klauspost) in [fatih/color#228 - ci: update Go and Staticcheck versions by [@​fatih](https://togithub.com/fatih) in [fatih/color#222 - Bump golang.org/x/sys from 0.14.0 to 0.17.0 by [@​dependabot](https://togithub.com/dependabot) in [fatih/color#221 - Bump actions/setup-go from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [fatih/color#217 - Bump golang.org/x/sys from 0.17.0 to 0.18.0 by [@​dependabot](https://togithub.com/dependabot) in [fatih/color#224 #### New Contributors - [@​klauspost](https://togithub.com/klauspost) made their first contribution in [fatih/color#228 **Full Changelog**: fatih/color@v1.16.0...v1.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/hetznercloud/cli). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmt.Printlnwill add spaces between elements when there is multiple parameters sent. This is also described in the documentation of this library:Spaces are always added between operands and a newline is appended.When wrapping the colors parameters were combined using
fmt.Sprint(a...)- which does not space out parameters.Use
fmt.Sprintlnto combine parameters.Fixes #218