Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spaceship] Fix filtering of Mac devices when trying to create a macOS profile #21915

Merged
merged 3 commits into from
Mar 9, 2024
Merged

[spaceship] Fix filtering of Mac devices when trying to create a macOS profile #21915

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba23e98
Update the list of device_classes to filter on for mac platform
AliSoftware Mar 8, 2024
393359f
Adjust comment to update date at which we checked the API docs
AliSoftware Mar 8, 2024
0804bae
Fix typo in comment
AliSoftware Mar 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions spaceship/lib/spaceship/connect_api/models/device.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,9 @@ module DeviceClass
APPLE_TV = "APPLE_TV"
MAC = "MAC"

# As of 2022-11-12, this is not officially supported by App Store Connect API
# As of 2024-03-1082, this is not _officially_ supported by App Store Connect API (according to API docs)—yet still used in the API responses
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024-03-08?

AliSoftware marked this conversation as resolved.
Show resolved Hide resolved
APPLE_SILICON_MAC = "APPLE_SILICON_MAC"
INTEL_MAC = "INTEL_MAC"
end

module Status
Expand Down Expand Up @@ -94,7 +95,9 @@ def self.devices_for_platform(platform: nil, include_mac_in_profiles: false, cli
]
when :macos, :catalyst
[
Spaceship::ConnectAPI::Device::DeviceClass::MAC
Spaceship::ConnectAPI::Device::DeviceClass::MAC,
Spaceship::ConnectAPI::Device::DeviceClass::APPLE_SILICON_MAC,
Spaceship::ConnectAPI::Device::DeviceClass::INTEL_MAC
]
else
[]
Expand Down