Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[match] improve encryption internals, solving flaky test (#21663) #21790

Merged
merged 22 commits into from
Jan 18, 2024
Merged

[match] improve encryption internals, solving flaky test (#21663) #21790

merged 22 commits into from
Jan 18, 2024

Commits on Jan 10, 2024

  1. Rewrite the encryption layer for match, keeping backwards compatibility

    @lacostej
    lacostej committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    f6aeb5c View commit details
    Browse the repository at this point in the history

  2. match: add companion script to enc

    @lacostej
    lacostej committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    1828882 View commit details
    Browse the repository at this point in the history

  3. Update documentation related to encryption

    @lacostej
    lacostej committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    4e68ebb View commit details
    Browse the repository at this point in the history

  4. rubocop

    @lacostej
    lacostej committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    c5d33cd View commit details
    Browse the repository at this point in the history

  5. Rename match_enc file

    @lacostej
    lacostej committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    e5b271a View commit details
    Browse the repository at this point in the history

  6. Remove deprecation warning from OpenSSL

    @lacostej
    lacostej committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    4332cc9 View commit details
    Browse the repository at this point in the history

  7. Attempt at lower casing the cipher to allow older rubies to find it

    @lacostej
    lacostej committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    8c04014 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. address code review

    @lacostej
    lacostej committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    e07a6f2 View commit details
    Browse the repository at this point in the history

  2. Adjust CLI usage and arg checks

    @lacostej
    lacostej committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    7170033 View commit details
    Browse the repository at this point in the history

  3. more doc cleanups

    @lacostej
    lacostej committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    91f0b00 View commit details
    Browse the repository at this point in the history

  4. rubocop

    @lacostej
    lacostej committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    133d090 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Update match/lib/match/encryption/encryption.rb 

    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    @lacostej @rogerluan
    lacostej and rogerluan committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    471c3a0 View commit details
    Browse the repository at this point in the history

  2. Update match/lib/match/encryption/encryption.rb 

    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    @lacostej @rogerluan
    lacostej and rogerluan committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    cb496ec View commit details
    Browse the repository at this point in the history

  3. Update bin/match_file 

    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    @lacostej @rogerluan
    lacostej and rogerluan committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    850a472 View commit details
    Browse the repository at this point in the history

  4. Update match/lib/match/encryption/encryption.rb 

    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    @lacostej @rogerluan
    lacostej and rogerluan committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    0d864ca View commit details
    Browse the repository at this point in the history

  5. Update match/lib/match/encryption/encryption.rb 

    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    @lacostej @rogerluan
    lacostej and rogerluan committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    0394f34 View commit details
    Browse the repository at this point in the history

  6. Monkey patch match_file to support control-c :)

    @lacostej
    lacostej committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    035cbd1 View commit details
    Browse the repository at this point in the history

  7. Fix typo

    @lacostej
    lacostej committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    10405ee View commit details
    Browse the repository at this point in the history

  8. Use keyword parameters in main entry point for encryption

    @lacostej
    lacostej committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    237adc0 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Rubocop

    @lacostej
    lacostej committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    56578d8 View commit details
    Browse the repository at this point in the history

  2. ctrl-c support requires ruby 2.7.1 apparently, so aborting instead

    @lacostej
    lacostej committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    7ed2e06 View commit details
    Browse the repository at this point in the history

  3. encryption: keyword parameters all the way, also add the test that go… 

    …t lost
    @lacostej
    lacostej committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    4c6f360 View commit details
    Browse the repository at this point in the history