Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate ruby 3.2.2 on circle, adjust tests #21664

Merged
merged 9 commits into from
Nov 27, 2023

Conversation

lacostej
Copy link
Collaborator

@lacostej lacostej commented Nov 24, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Supoort ruby 3.2.2 in build

Description

Testing Steps

@lacostej lacostej changed the title Activate ruby 3.2.2 on circlea [WIP] Activate ruby 3.2.2 on circle, adjust tests Nov 24, 2023
fastlane/spec/actions_helper_spec.rb Outdated Show resolved Hide resolved
@lacostej
Copy link
Collaborator Author

Build failed due to #21663, so ignoring. Merging.

@lacostej lacostej merged commit 2860bac into fastlane:master Nov 27, 2023
1 of 2 checks passed
@lacostej lacostej deleted the feature/test_ruby_3.2.2 branch November 27, 2023 10:59
SubhrajyotiSen pushed a commit to KeepTruckin/fastlane that referenced this pull request Jan 17, 2024
* Activate ruby 3.2.2 on circlea

* circle doc

* Update rspec and webmock to pass tests on ruby 3.2+

* require SyntaxError content changed in ruby 3.2

* circle: Run tests on latest xcode version

* rubocop

* webmock 3.19.1 breaks tests

* Find a version of webmock that works, and make the tests pass by passing the expected hash instead of keywords

* Better document the difference between ruby 3.1 and 3.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants