Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[supply] introduce a new synchronization logic for screenshots #21498

Merged
merged 7 commits into from
Sep 15, 2023
Merged

[supply] introduce a new synchronization logic for screenshots #21498

merged 7 commits into from
Sep 15, 2023

Commits on Sep 5, 2023

  1. [supply] Implement screenshots upload sync 

    Compare the checksum of the images to be uploaded with the ones already in remote, and skip upload if they already match
    @AliSoftware
    AliSoftware committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    c89d346 View commit details
    Browse the repository at this point in the history

  2. Add unit tests

    @AliSoftware
    AliSoftware committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    5bad9ce View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Improve YARD doc

    @AliSoftware
    AliSoftware committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    0df5632 View commit details
    Browse the repository at this point in the history

  2. fix typo in comment

    @AliSoftware
    AliSoftware committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    fba7f23 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    @AliSoftware @rogerluan
    AliSoftware and rogerluan committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    c0ee77d View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Remove redundant condition

    @AliSoftware
    AliSoftware committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    51c147e View commit details
    Browse the repository at this point in the history

  2. Add assertion about not deleting _all_ screenshots when `sync_image_u… 

    …pload` is set
    @AliSoftware
    AliSoftware committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    7f10c95 View commit details
    Browse the repository at this point in the history