Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] add minor branding guidelines to CONTRIBUTING.md #21495

Merged
merged 20 commits into from
Sep 3, 2023
Merged

[docs] add minor branding guidelines to CONTRIBUTING.md #21495

merged 20 commits into from
Sep 3, 2023

Commits on Sep 1, 2023

  1. Add minor branding guidelines.

    @rogerluan
    rogerluan committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    f96e8b1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rogerluan-branding

    @rogerluan
    rogerluan committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    21b2344 View commit details
    Browse the repository at this point in the history

  3. Improve checks on branding style.

    @rogerluan
    rogerluan committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    5c3ad2a View commit details
    Browse the repository at this point in the history

  4. Prefer lowercase over lower case. 

    https://english.stackexchange.com/a/59413
    @rogerluan
    rogerluan committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    819cb2f View commit details
    Browse the repository at this point in the history

  5. Adequate existing docs to branding guidelines.

    @rogerluan
    rogerluan committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    90a4131 View commit details
    Browse the repository at this point in the history

  6. Improve lowercase checking algorithm to cover all wEiRD caSEs.

    @rogerluan
    rogerluan committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    db38684 View commit details
    Browse the repository at this point in the history

  7. Improve wording. 

    Co-authored-by: Aaron Brager <getaaron@gmail.com>
    @rogerluan @getaaron
    rogerluan and getaaron committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    1627cd6 View commit details
    Browse the repository at this point in the history

  8. Refactor regex to take into account potential false positives.

    @rogerluan
    rogerluan committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    b488bc4 View commit details
    Browse the repository at this point in the history

  9. Add unit tests for the tool name formatting tests.

    @rogerluan
    rogerluan committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    95b0ede View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2023

  1. Use full name for the variable.

    @rogerluan
    rogerluan committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    e618c91 View commit details
    Browse the repository at this point in the history

  2. Add missing test cases and fix typo in method.

    @rogerluan
    rogerluan committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    3347960 View commit details
    Browse the repository at this point in the history

  3. Move test to actual specs.

    @rogerluan
    rogerluan committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    93405fb View commit details
    Browse the repository at this point in the history

  4. Run rubocop.

    @rogerluan
    rogerluan committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    18ee73d View commit details
    Browse the repository at this point in the history

  5. Commit missing part.

    @rogerluan
    rogerluan committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    23117ca View commit details
    Browse the repository at this point in the history

  6. Remove emoji indicators.

    @rogerluan
    rogerluan committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    54639cd View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2023

  1. Remove emoji from specs too 😅

    @rogerluan
    rogerluan committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    4448af3 View commit details
    Browse the repository at this point in the history

  2. Use File.readlines instead of File.read + split

    @AliSoftware
    AliSoftware committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    23b1655 View commit details
    Browse the repository at this point in the history

  3. Also detect formatting issues at start of line

    @AliSoftware
    AliSoftware committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    2079206 View commit details
    Browse the repository at this point in the history

  4. Fix violations found by new implementation

    @AliSoftware
    AliSoftware committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    3c4b46a View commit details
    Browse the repository at this point in the history

  5. Add the "features" word back to the table.

    @rogerluan
    rogerluan committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    057829d View commit details
    Browse the repository at this point in the history