Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] stop generating rspec temp file in current directory #21466

Merged
merged 2 commits into from
Aug 24, 2023
Merged

[tests] stop generating rspec temp file in current directory #21466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ed5d3c
Create temp file in tempfile dir, to avoid creating a temp file in cu…
rogerluan Aug 16, 2023
43a0e20
Merge branch 'master' into rogerluan-remove-rspec-leftovers
rogerluan Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pilot/spec/test_exporter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
describe ".export_testers" do
let(:fake_tester_exporter) { Pilot::TesterExporter.new }
let(:fake_tester_manager) { double("tester manager") }
let(:fake_testers_file_path) { "fake testers_file_path" }
let(:fake_testers_file_path) { Tempfile.new("fake testers_file_path").path }
let(:fake_apple_id) { "fake apple_id" }
let(:fake_app_identifier) { "fake app_identifier" }
let(:fake_input_options) do
Expand Down
2 changes: 1 addition & 1 deletion pilot/spec/tester_importer_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

context "when testers CSV file path is given" do
let(:fake_tester_manager) { double("tester manager") }
let(:fake_testers_file_path) { "fake testers_file_path" }
let(:fake_testers_file_path) { Tempfile.new("fake testers_file_path").path }
let(:fake_input_options) do
{
testers_file_path: fake_testers_file_path
Expand Down