-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[trainer] fix issues where number of failures would always be zero #21432
Merged
rogerluan
merged 6 commits into
fastlane:master
from
tahirmt:fix-trainer-not-reporting-failures
Jan 10, 2024
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c8b956f
Sanitize both identifier and test case
tahirmt 19b11fc
Add unit tests
tahirmt fb16a4e
Replace String extension with individual rules with simpler `proc` re…
rogerluan 0281dc5
Add `.gitattributes` and represent .xcresult as binary.
rogerluan fb872ac
Revert "Add `.gitattributes` and represent .xcresult as binary."
rogerluan 9d94443
Merge branch 'master' into fix-trainer-not-reporting-failures
rogerluan File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
...~4VqMqsI5lOfxRppnud6-VDWcNsU8J7VgFCJfW2dXPwOcAkvU-I8Um5yp9n0Zv6nr3VmcxYggaVMDFfR0U_vjKw==
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
[] |
Binary file added
BIN
+2.74 KB
...~7tsPhGURwp2J0Yr2xLwDkXd5H9rvQnnXoc484tVlZxE0zPq6ZxlGj-xtLgKa55IRf6U1u3DcC4nThWQCFyQWtw==
Binary file not shown.
Binary file added
BIN
+288 Bytes
...~7wgiMormC4x4enRXpucJYkDFXsPwlIELWjwYYthhXqpoq1Jf3-pPX5RWUJNKLGrlSAnPrunazVEyYzzqPvwMdA==
Binary file not shown.
1 change: 1 addition & 0 deletions
1
...~96Gg-fMtc5VM-luuv1gvnNzTxyoeYQUgP4hhLCxgMi0c2wQPCGVwRe19qboVX1d3C9dnfZsZBpqv1B28isTPXA==
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
[{"name":"testmanagerd.log","type":1}] |
Binary file added
BIN
+416 Bytes
...~Dy9B07v7JcxXSDNAYT_cJWr3uvut6rtl1oSlYvgZ9vg5LIfHXOR_NANkgLj-Ts9MtIpbQDWei3dntyVgyXx-UQ==
Binary file not shown.
Binary file added
BIN
+117 Bytes
...~HDNTGnB2FATq2C5mp44gsBoqg2tGbCBxHGz-OEOd7A4lBLUy-yn6JwIRXbr8KH1IzVATAPcw3Zn6xdy7ioiLVQ==
Binary file not shown.
Binary file added
BIN
+1.18 KB
...~HjnMbbAqP4qhK3WyCTi6tbfycJkNOUH6P4C1yK-qhxHc5VJRpQWtfEml_wNcFSW-_PemyWE9zkPyQmKvjrvmbw==
Binary file not shown.
1 change: 1 addition & 0 deletions
1
...~OgxMYTpxs86Jl2k5uEAKBK-WUl1KFLEpGLcYG1Zcp2XvjXeYVsGbuW4XAKDQL8BC9Uk4onT3R_BhKU1jNPdjpA==
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
[{"name":"SpaceTestsTests-537E3596-221E-4A31-9389-071C5541B922","type":2},{"name":"scheduling.log","type":1}] |
Binary file added
BIN
+1.94 KB
...~SsRyiCHDfQl2m19SwdRuZY_vhc88s24Xb6jgs7SXLFpWpNV6sGPwMav-Pin-3_-rheMqlGi_0gxrcwMBrUii1w==
Binary file not shown.
Binary file added
BIN
+290 Bytes
...~TbaJ7YZ2rLSKefY8s8kIJwRlnJw1zzAReF82HpwBmwzs1QjJVvlbAoLeLsbgckVIWionKTnQB8CXjzNyJJ-sng==
Binary file not shown.
Binary file added
BIN
+1.19 KB
...~YxHeunnkhdMlia-g23AMt_6XVxlW2CHTRsWKIgO1KJGUokPzoO6JZCzw9bzjIlUW0FEenbUTiQOnK9EVS388KA==
Binary file not shown.
Binary file added
BIN
+193 Bytes
...~aC_M8PwRbiGMJPd_fGN8QYgz05tLco7dDKBMF8UT-8mGYSsYRts4ieQBgbpqDMzMH419zNEJKIcmqFfnljUytA==
Binary file not shown.
Binary file added
BIN
+892 Bytes
...~bc0-HDG3G9sjnJO1MxacCownHuqI7v_dC_54GWNc4luhzWVZD3LFEVvG-mRQNwwIkPE66UKlH8zZJqGovjviAg==
Binary file not shown.
Binary file added
BIN
+8.77 KB
...~jmAosCXh5KF2Um2yHXkDITU_RJ5Wo2rpHVk7fxekThnBvAlAtUwp_0xEUsHc1cZohuP5ljks-vA49BtNCSiKcA==
Binary file not shown.
Binary file added
BIN
+32.6 KB
...~minvEuWnOqyIKSjgc-6Q7vITnmIGNrfhOFVCLd1WugzmLC6RsFTPwE6trHssX-o-zTstvD4Rl4wHcvRyRRRZxA==
Binary file not shown.
Binary file added
BIN
+1 Byte
...~4VqMqsI5lOfxRppnud6-VDWcNsU8J7VgFCJfW2dXPwOcAkvU-I8Um5yp9n0Zv6nr3VmcxYggaVMDFfR0U_vjKw==
Binary file not shown.
Binary file added
BIN
+1 Byte
...~7tsPhGURwp2J0Yr2xLwDkXd5H9rvQnnXoc484tVlZxE0zPq6ZxlGj-xtLgKa55IRf6U1u3DcC4nThWQCFyQWtw==
Binary file not shown.
Binary file added
BIN
+1 Byte
...~7wgiMormC4x4enRXpucJYkDFXsPwlIELWjwYYthhXqpoq1Jf3-pPX5RWUJNKLGrlSAnPrunazVEyYzzqPvwMdA==
Binary file not shown.
Binary file added
BIN
+67 Bytes
...~96Gg-fMtc5VM-luuv1gvnNzTxyoeYQUgP4hhLCxgMi0c2wQPCGVwRe19qboVX1d3C9dnfZsZBpqv1B28isTPXA==
Binary file not shown.
Binary file added
BIN
+1 Byte
...~Dy9B07v7JcxXSDNAYT_cJWr3uvut6rtl1oSlYvgZ9vg5LIfHXOR_NANkgLj-Ts9MtIpbQDWei3dntyVgyXx-UQ==
Binary file not shown.
Binary file added
BIN
+133 Bytes
...~HDNTGnB2FATq2C5mp44gsBoqg2tGbCBxHGz-OEOd7A4lBLUy-yn6JwIRXbr8KH1IzVATAPcw3Zn6xdy7ioiLVQ==
Binary file not shown.
Binary file added
BIN
+1 Byte
...~HjnMbbAqP4qhK3WyCTi6tbfycJkNOUH6P4C1yK-qhxHc5VJRpQWtfEml_wNcFSW-_PemyWE9zkPyQmKvjrvmbw==
Binary file not shown.
Binary file added
BIN
+133 Bytes
...~OgxMYTpxs86Jl2k5uEAKBK-WUl1KFLEpGLcYG1Zcp2XvjXeYVsGbuW4XAKDQL8BC9Uk4onT3R_BhKU1jNPdjpA==
Binary file not shown.
Binary file added
BIN
+331 Bytes
...~SsRyiCHDfQl2m19SwdRuZY_vhc88s24Xb6jgs7SXLFpWpNV6sGPwMav-Pin-3_-rheMqlGi_0gxrcwMBrUii1w==
Binary file not shown.
Binary file added
BIN
+1 Byte
...~TbaJ7YZ2rLSKefY8s8kIJwRlnJw1zzAReF82HpwBmwzs1QjJVvlbAoLeLsbgckVIWionKTnQB8CXjzNyJJ-sng==
Binary file not shown.
Binary file added
BIN
+1 Byte
...~YxHeunnkhdMlia-g23AMt_6XVxlW2CHTRsWKIgO1KJGUokPzoO6JZCzw9bzjIlUW0FEenbUTiQOnK9EVS388KA==
Binary file not shown.
Binary file added
BIN
+199 Bytes
...~aC_M8PwRbiGMJPd_fGN8QYgz05tLco7dDKBMF8UT-8mGYSsYRts4ieQBgbpqDMzMH419zNEJKIcmqFfnljUytA==
Binary file not shown.
Binary file added
BIN
+67 Bytes
...~bc0-HDG3G9sjnJO1MxacCownHuqI7v_dC_54GWNc4luhzWVZD3LFEVvG-mRQNwwIkPE66UKlH8zZJqGovjviAg==
Binary file not shown.
Binary file added
BIN
+1 Byte
...~jmAosCXh5KF2Um2yHXkDITU_RJ5Wo2rpHVk7fxekThnBvAlAtUwp_0xEUsHc1cZohuP5ljks-vA49BtNCSiKcA==
Binary file not shown.
Binary file added
BIN
+1 Byte
...~minvEuWnOqyIKSjgc-6Q7vITnmIGNrfhOFVCLd1WugzmLC6RsFTPwE6trHssX-o-zTstvD4Rl4wHcvRyRRRZxA==
Binary file not shown.
29 changes: 29 additions & 0 deletions
29
trainer/spec/fixtures/Test.with_spaces.xcresult/Info.plist
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
<plist version="1.0"> | ||
<dict> | ||
<key>dateCreated</key> | ||
<date>2023-07-31T19:01:10Z</date> | ||
<key>externalLocations</key> | ||
<array/> | ||
<key>rootId</key> | ||
<dict> | ||
<key>hash</key> | ||
<string>0~SsRyiCHDfQl2m19SwdRuZY_vhc88s24Xb6jgs7SXLFpWpNV6sGPwMav-Pin-3_-rheMqlGi_0gxrcwMBrUii1w==</string> | ||
</dict> | ||
<key>storage</key> | ||
<dict> | ||
<key>backend</key> | ||
<string>fileBacked2</string> | ||
<key>compression</key> | ||
<string>standard</string> | ||
</dict> | ||
<key>version</key> | ||
<dict> | ||
<key>major</key> | ||
<integer>3</integer> | ||
<key>minor</key> | ||
<integer>39</integer> | ||
</dict> | ||
</dict> | ||
</plist> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is a regression. See #21432 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix #21990