Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Only run all mac jobs on master and version bump branches #21088

Merged
merged 2 commits into from
Apr 16, 2023
Merged

[ci] Only run all mac jobs on master and version bump branches #21088

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c1f97d
[ci] Only run all mac jobs on master and version bump branches
joshdholtz Feb 28, 2023
f3c57f2
Fix main to master
joshdholtz Apr 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ orbs:
shellcheck: circleci/shellcheck@2.2.2 # brew install shellcheck stopped working so using this

aliases:
- &important-branches
filters:
branches:
only:
- main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we switch the default branch to main? We should try that switching, though.

Suggested change
- main
- master

- /^version\-bump\-.*/
# common - cache
- &cache_restore_git
restore_cache:
Expand Down Expand Up @@ -258,16 +264,19 @@ workflows:
name: 'Execute tests on macOS (Xcode 11.7.0, Ruby 2.6)'
xcode_version: '11.7.0'
ruby_version: '2.6'
<<: *important-branches
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
https://circleci.com/docs/configuration-reference/#jobfilters

- tests_macos:
name: 'Execute tests on macOS (Xcode 12.5.1, Ruby 2.7)'
xcode_version: '12.5.1'
ruby_version: '2.7'
ruby_opt: -W:deprecated
<<: *important-branches
- tests_macos:
name: 'Execute tests on macOS (Xcode 13.0.0, Ruby 3.0)'
xcode_version: '13.0.0'
ruby_version: '3.0'
ruby_opt: -W:deprecated
<<: *important-branches
- tests_macos:
name: 'Execute tests on macOS (Xcode 13.0.0, Ruby 3.1)'
xcode_version: '13.0.0'
Expand Down