[pilot] do not advertise the skip_waiting_for_build_processing option when it is already set
#21730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacostej
requested changes
Dec 17, 2023
| @@ -72,8 +72,10 @@ def upload(options) | |||
| # Calling login again here is needed if login was not called during 'start' | |||
There was a problem hiding this comment.
We could also put a UI.message in line 68, stating
UI.important("`skip_waiting_for_build_processing` used and `changelog` supplied - will wait until build appears on AppStoreConnect, update the changelog and then skip the rest of the remaining of the processing steps.")
That way we log something in all scenarios, and that would make it easier for someone with less knowledge understand better what is going on in that particular case.
There was a problem hiding this comment.
I took care of this. I struggled a bit with creating new spec tests. Let me know if I got anything wrong.
There was a problem hiding this comment.
@lacostej Please take another look when you get a chance
lacostej
changed the title
skip_waiting_for_build_processing option when it is already set
robinkunde
force-pushed
the
silenceSkipWaitingAdWhenSet
branch
from
e863101
to
6775d1d
Compare
lacostej
approved these changes
Jan 12, 2024
rogerluan
changed the title
skip_waiting_for_build_processing option when it is already setskip_waiting_for_build_processing option when it is already set
rogerluan
reviewed
Jan 14, 2024
rogerluan
approved these changes
Jan 14, 2024
|
Thanks @robinkunde :) |
|
Thanks for fixing the issue I accidentally caused @lacostej ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Reduces superfluous output when uploading builds
Description
Testing Steps