Merge branch 'fastlane:master' into silenceSkipWaitingAdWhenSet

.circleci/config.yml

@@ -130,15 +130,15 @@ jobs:
 
   tests_ubuntu:
     parameters:
-      ruby_version:
+      image:
         type: string
     environment:
       CIRCLE_TEST_REPORTS: '~/test-reports'
       LC_ALL: 'C.UTF-8'
       LANG: 'C.UTF-8'
       FASTLANE_ITUNES_TRANSPORTER_PATH: .bundle
     docker:
-      - image: << parameters.ruby_version >>
+      - image: << parameters.image >>
     steps:
       - *cache_restore_git
       - checkout
@@ -196,10 +196,10 @@ jobs:
 
   validate_documentation:
     parameters:
-      ruby_version:
+      image:
         type: string
     docker:
-      - image: << parameters.ruby_version >>
+      - image: << parameters.image >>
     steps:
       - *cache_restore_git
       - checkout
@@ -217,10 +217,10 @@ jobs:
 
   lint_source_code:
     parameters:
-      ruby_version:
+      image:
         type: string
     docker:
-      - image: << parameters.ruby_version >>
+      - image: << parameters.image >>
     steps:
       - *cache_restore_git
       - checkout
@@ -233,13 +233,13 @@ jobs:
 
   modules_load_up_tests:
     parameters:
-      ruby_version:
+      image:
         type: string
     environment:
       LC_ALL: C.UTF-8
       LANG: C.UTF-8
     docker:
-      - image: << parameters.ruby_version >>
+      - image: << parameters.image >>
     shell: /bin/bash --login -eo pipefail
     steps:
       - *cache_restore_git
@@ -307,17 +307,17 @@ workflows:
           ruby_opt: -W:deprecated
       - tests_ubuntu:
           name: 'Execute tests on Ubuntu'
-          ruby_version: 'fastlanetools/ci:0.3.0'
+          image: 'fastlanetools/ci:0.3.0'
       - validate_fastlane_swift_generation:
           name: 'Validate Fastlane.swift generation'
           xcode_version: '12.5.1'
           ruby_version: '2.7'
       - validate_documentation:
           name: 'Validate Documentation'
-          ruby_version: 'fastlanetools/ci:0.3.0'
+          image: 'cimg/ruby:3.2.2'
       - lint_source_code:
           name: 'Lint source code'
-          ruby_version: 'cimg/ruby:2.6'
+          image: 'cimg/ruby:2.6'
       - modules_load_up_tests:
           name: 'Modules load up tests'
-          ruby_version: 'cimg/ruby:2.6'
+          image: 'cimg/ruby:2.6'

.github/workflows/issues.yml

@@ -1,14 +1,16 @@
-name: Processing issues
-on: 
+---
+name: Process issues
+on:
   issues:
-    types: [opened]
+    types:
+      - opened
 
-jobs:   
+jobs:
   fastlane-env:
-    name: fastlane env reminder
-    runs-on: ubuntu-latest    
+    name: Remind user about posting their fastlane env
+    runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@master
-    - uses: fastlane/github-actions/fastlane-env-reminder@latest
-      with:
-        repo-token: "${{ secrets.BOT_GITHUB_TOKEN }}"
+      - uses: actions/checkout@master
+      - uses: fastlane/github-actions/fastlane-env-reminder@latest
+        with:
+          repo-token: '${{ secrets.BOT_GITHUB_TOKEN }}'

.github/workflows/lock.yml

@@ -1,14 +1,15 @@
-# Locking closed, inactive issues and pull requests
-name: Locking issues and pull requests
+---
+name: Lock issues and pull requests
 on:
   schedule:
-  - cron: "0 0 * * *"
+    - cron: "0 0 * * *" # Every day at midnight
 
 jobs:
   lock:
+    name: Lock closed and inactive issues and pull requests
     runs-on: ubuntu-latest
     steps:
-    - uses: fastlane/github-actions/lock@latest
-      with:
-        repo-token: ${{ secrets.BOT_GITHUB_TOKEN }}
-        days-before-lock: 60
+      - uses: fastlane/github-actions/lock@latest
+        with:
+          repo-token: '${{ secrets.BOT_GITHUB_TOKEN }}'
+          days-before-lock: 60

.github/workflows/release.yml

@@ -1,18 +1,20 @@
-name: Processing release
-on: 
+---
+name: Process release
+on:
   release:
-    types: [published]
+    types:
+      - published
 
-jobs:   
-  communicate-on-pull-request-released:
-    name: communicate on pull request released
+jobs:
+  announce-release-on-released-pull-requests:
+    name: Announce release on released pull requests
     runs-on: ubuntu-latest
     steps:
-    - name: Git checkout
-      uses: actions/checkout@master
-      with:
-        ref: refs/heads/master
-    - name: Communicate on PR released
-      uses: fastlane/github-actions/communicate-on-pull-request-released@latest
-      with:
-        repo-token: ${{ secrets.BOT_GITHUB_TOKEN }}
+      - name: Git checkout
+        uses: actions/checkout@master
+        with:
+          ref: refs/heads/master
+      - name: Announce release on released pull requests
+        uses: fastlane/github-actions/communicate-on-pull-request-released@latest
+        with:
+          repo-token: '${{ secrets.BOT_GITHUB_TOKEN }}'

.github/workflows/tags.yml

@@ -1,15 +1,17 @@
+---
+name: Deploy to Homebrew
 on:
   push:
-    tags: 'v*'
+    tags: 'v*' # Push events to tags matching v*
 
 jobs:
   homebrew:
     name: Bump Homebrew formula
     runs-on: ubuntu-latest
     steps:
       - uses: mislav/bump-homebrew-formula-action@v3.1
-        if: "!contains(github.ref, '-')" # skip prereleases
+        if: "!contains(github.ref, '-')" # Skip prereleases
         with:
           formula-name: fastlane
         env:
-          COMMITTER_TOKEN: ${{ secrets.HOMEBREW_COMMITTER_TOKEN }}
+          COMMITTER_TOKEN: '${{ secrets.HOMEBREW_COMMITTER_TOKEN }}'