Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] stop generating rspec temp file in current directory #21466

Merged
merged 2 commits into from Aug 24, 2023

Conversation

rogerluan
Copy link
Member

@rogerluan rogerluan commented Aug 16, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've updated the documentation if necessary.

Motivation and Context

Every time bundle exec rspec is run, this file was being created in the current dir:

image

This was bothering me, so this PR fixes just that 😄

Description

The file will be created in the temp dir instead, and thus will be deleted when the OS deems necessary.

Testing Steps

To test the file generation, run bundle exec rspec pilot/spec/test_exporter_spec.rb and/or bundle exec rspec pilot/spec/tester_importer_spec.rb in master.

To test this branch, modify your Gemfile as:

gem 'fastlane', git: 'https://github.com/fastlane/fastlane.git', branch: 'rogerluan-update-circleci'

And run bundle install to apply the changes.

Then run bundle exec rspec pilot/spec/test_exporter_spec.rb and/or bundle exec rspec pilot/spec/tester_importer_spec.rb again to verify that the file isn't being created in the current dir anymore.

Copy link
Member

@crazymanish crazymanish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ This has bothered me for a while too, thanks for finally fixing it!

@rogerluan rogerluan merged commit dbb84f9 into master Aug 24, 2023
14 checks passed
@rogerluan rogerluan deleted the rogerluan-remove-rspec-leftovers branch August 24, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants