add iPhone 14 Pro / 6.1" display type #21393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snatchev
force-pushed
the
update-screenshot-display-types
branch
3 times, most recently
from
ec4b41d
to
54a2a54
Compare
snatchev
force-pushed
the
update-screenshot-display-types
branch
from
54a2a54
to
750789f
Compare
milch
approved these changes
Jul 20, 2023
ainame
approved these changes
Jul 21, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Resolves #21065 -- add support for iPhone 14 Pro 6.1" display type.
As per the documentation https://developer.apple.com/help/app-store-connect/reference/screenshot-specifications
The 6.1 Display type is now for the iPhone 14 Pro. It appears that this display size was for the iPhone XR which now must be uploaded as a 6.5" display size.
Description
Testing Steps