Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fastlane screenshots are always off by 1 pixels. #21759

Open
rafcortina opened this issue Dec 30, 2023 · 6 comments
Open

Fastlane screenshots are always off by 1 pixels. #21759

rafcortina opened this issue Dec 30, 2023 · 6 comments

Comments

@rafcortina
Copy link

✅ fastlane environment ✅

Stack

Key Value
OS 13.6.1
Ruby 3.2.2
Bundler? false
Git git version 2.39.3 (Apple Git-145)
Installation Source /opt/homebrew/Cellar/fastlane/2.217.0/libexec/bin/fastlane
Host macOS 13.6.1 (22G313)
Ruby Lib Dir /opt/homebrew/Cellar/ruby/3.2.2_1/lib
OpenSSL Version OpenSSL 3.1.1 30 May 2023
Is contained false
Is homebrew true
Is installed via Fabric.app false
Xcode Path /Applications/Xcode.app/Contents/Developer/
Xcode Version 15.1
Swift Version 5.9.2

System Locale

Variable Value
LANG en_US.UTF-8 ✅
LC_ALL
LANGUAGE

fastlane files:

`./Fastfile` 
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

default_platform(:ios)

platform :ios do
  desc "Generate new localized screenshots"
  lane :screenshots do
    snapshot
    deliver
  end
end
`./Appfile` 
app_identifier("co.firednotfired.app") # The bundle identifier of your app
apple_id("rafcortina@gmail.com") # Your Apple Developer Portal username

itc_team_id("118346210") # App Store Connect Team ID
team_id("GQBZ6XM4M7") # Developer Portal Team ID

# For more information about the Appfile, see:
#     https://docs.fastlane.tools/advanced/#appfile

fastlane gems

Gem Version Update-Status
fastlane 2.217.0 ✅ Up-To-Date

Loaded fastlane plugins:

No plugins Loaded

Loaded gems
Gem Version
error_highlight 0.5.1
did_you_mean 1.6.3
syntax_suggest 1.0.2
artifactory 3.0.15
babosa 1.0.4
bundler 2.4.10
rexml 3.2.6
CFPropertyList 3.0.6
colored 1.2
highline 2.0.3
commander 4.6.0
dotenv 2.8.1
emoji_regex 3.2.3
faraday-em_http 1.0.0
faraday-em_synchrony 1.0.0
faraday-excon 1.1.0
faraday-httpclient 1.0.1
multipart-post 2.3.0
faraday-multipart 1.0.4
faraday-net_http 1.0.1
faraday-net_http_persistent 1.2.0
faraday-patron 1.0.0
faraday-rack 1.0.0
faraday-retry 1.0.3
ruby2_keywords 0.0.5
faraday 1.10.3
faraday_middleware 1.2.0
domain_name 0.6.20231109
http-cookie 1.0.5
faraday-cookie_jar 0.0.7
gh_inspector 1.1.3
uber 0.1.0
declarative 0.0.20
trailblazer-option 0.1.2
representable 3.2.0
retriable 3.1.2
mini_mime 1.1.5
httpclient 2.8.3
webrick 1.8.1
google-apis-core 0.11.2
google-apis-playcustomapp_v1 0.13.0
google-apis-iamcredentials_v1 0.17.0
google-apis-storage_v1 0.29.0
rake 13.1.0
digest-crc 0.6.5
google-cloud-storage 1.45.0
jwt 2.7.1
mini_magick 4.12.0
naturally 2.2.1
optparse 0.1.1
rubyzip 2.3.2
security 0.1.3
simctl 1.6.10
terminal-notifier 2.0.0
unicode-display_width 2.5.0
terminal-table 3.0.2
tty-cursor 0.7.1
tty-spinner 0.9.3
word_wrap 1.0.0
atomos 0.1.3
claide 1.1.0
colored2 3.1.2
nanaimo 0.3.0
xcodeproj 1.23.0
rouge 2.0.7
xcpretty 0.3.0
xcpretty-travis-formatter 1.0.1
set 1.0.3
public_suffix 5.0.4
addressable 2.8.6
aws-eventstream 1.3.0
aws-sigv4 1.8.0
aws-partitions 1.874.0
jmespath 1.6.2
aws-sdk-core 3.190.1
aws-sdk-kms 1.75.0
aws-sdk-s3 1.142.0
excon 0.108.0
fastimage 2.3.0
multi_json 1.15.0
signet 0.18.0
os 1.1.4
google-cloud-env 2.1.0
googleauth 1.9.1
google-apis-androidpublisher_v3 0.54.0
google-cloud-errors 1.3.1
google-cloud-core 1.6.1
json 2.7.1
plist 3.7.1
tty-screen 0.8.2
forwardable 1.3.3
logger 1.5.3
pathname 0.2.1
shellwords 0.1.0
cgi 0.3.6
date 3.3.3
timeout 0.3.1
securerandom 0.2.2
uri 0.12.1
openssl 3.1.0
digest 3.1.1
ipaddr 1.2.5
resolv 0.2.2
time 0.2.2
stringio 3.0.4
open-uri 0.3.0
mutex_m 0.1.2
net-http 0.3.2
net-protocol 0.2.1
ostruct 0.5.5
english 0.7.2
erb 4.0.2
abbrev 0.1.1
tempfile 0.1.3
delegate 0.3.0
fileutils 1.7.0
tmpdir 0.1.3
base64 0.1.1
singleton 0.1.1
open3 0.1.2
nkf 0.1.2
prettyprint 0.1.1
pp 0.4.0
find 0.1.1
yaml 0.2.1
psych 5.0.1

generated on: 2023-12-30
@whiskey
Copy link

whiskey commented Jan 2, 2024

To provide a litte more info, it's most likely just for the iPhone 15 Pro:

[16:19:29]: 🚫 Error: ./fastlane/screenshots/zh-Hans/iPhone 15 Pro-10-screenshot001.png - Invalid screen size (Actual size is 1178x2556. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)

@whiskey
Copy link

whiskey commented Jan 3, 2024

My way to mitigate this issue:

for i in ./fastlane/screenshots/**/iPhone\ 15\ Pro-*.png; do sips --resampleHeightWidth 2556 1179 $i;done

@lacostej
Copy link
Collaborator

lacostej commented Jan 4, 2024

This is similar to #21558.

If you wish to contribute, you may wish to try look at how iPhone 14 support was added in #21393.

@joejcon1
Copy link

joejcon1 commented Jan 5, 2024

duplicate issue to #21764 it seems although they are reproducing with a 10px delta on iPad simulators

I can reproduce on iPhone 15, iPhone 15 Pro and also iPhone 14 Pro simulators

@EddyLB
Copy link

EddyLB commented Jan 24, 2024

iPhone 14 Pro and 15 Pro screenshots:

  • produced manually: size of 1179x2556
  • produced with fastlane: 1178x2556
✅ fastlane environment ✅

Stack

Key Value
OS 14.3
Ruby 2.7.3
Bundler? true
Git git version 2.39.3 (Apple Git-145)
Installation Source ~/.gem/ruby/2.7.3/bin/fastlane
Host macOS 14.3 (23D56)
Ruby Lib Dir ~/.rubies/ruby-2.7.3/lib
OpenSSL Version OpenSSL 1.1.1l 24 Aug 2021
Is contained false
Is homebrew false
Is installed via Fabric.app false
Xcode Path /Applications/Xcode.app/Contents/Developer/
Xcode Version 15.2
Swift Version 5.9.2

System Locale

Variable Value
LANG en_US.UTF-8 ✅
LC_ALL en_US.UTF-8 ✅
LANGUAGE

fastlane files:

`./fastlane/Fastfile` 
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

ENV["FASTLANE_XCODEBUILD_SETTINGS_TIMEOUT"] = "120"

default_platform(:ios)

platform :ios do
  desc "Generate new localized screenshots"
  lane :screenshots do
    capture_screenshots(workspace: "piwigo.xcworkspace", scheme: "piwigoAppStore")
  end
end

update_app_identifier(
  xcodeproj: "piwigo.xcodeproj", 	# Optional path to xcodeproj, will use the first .xcodeproj if not set
  plist_path: "piwigo/Info.plist", 	# Path to info plist file, relative to xcodeproj
  app_identifier: "org.piwigo" 		# The App Identifier
)
`./fastlane/Appfile` 
app_identifier("org.piwigo") 		# The bundle identifier of your app
apple_id("…@…") # Your Apple email address
team_id("…")

# For more information about the Appfile, see:
#     https://docs.fastlane.tools/advanced/#appfile

fastlane gems

Gem Version Update-Status
fastlane 2.219.0 ✅ Up-To-Date

Loaded fastlane plugins:

No plugins Loaded

Loaded gems
Gem Version
did_you_mean 1.4.0
bundler 2.4.12
rake 13.1.0
rexml 3.2.6
CFPropertyList 3.0.6
public_suffix 5.0.4
addressable 2.8.6
artifactory 3.0.15
atomos 0.1.3
aws-eventstream 1.3.0
aws-partitions 1.883.0
aws-sigv4 1.8.0
jmespath 1.6.2
aws-sdk-core 3.190.3
aws-sdk-kms 1.76.0
aws-sdk-s3 1.142.0
babosa 1.0.4
claide 1.1.0
colored 1.2
colored2 3.1.2
highline 2.0.3
commander 4.6.0
declarative 0.0.20
digest-crc 0.6.5
domain_name 0.6.20240107
dotenv 2.8.1
emoji_regex 3.2.3
excon 0.109.0
faraday-em_http 1.0.0
faraday-em_synchrony 1.0.0
faraday-excon 1.1.0
faraday-httpclient 1.0.1
multipart-post 2.3.0
faraday-multipart 1.0.4
faraday-net_http 1.0.1
faraday-net_http_persistent 1.2.0
faraday-patron 1.0.0
faraday-rack 1.0.0
faraday-retry 1.0.3
ruby2_keywords 0.0.5
faraday 1.10.3
http-cookie 1.0.5
faraday-cookie_jar 0.0.7
faraday_middleware 1.2.0
fastimage 2.3.0
gh_inspector 1.1.3
jwt 2.7.1
multi_json 1.15.0
os 1.1.4
signet 0.18.0
googleauth 1.8.1
httpclient 2.8.3
mini_mime 1.1.5
trailblazer-option 0.1.2
uber 0.1.0
representable 3.2.0
retriable 3.1.2
google-apis-core 0.11.3
google-apis-androidpublisher_v3 0.54.0
google-apis-playcustomapp_v1 0.13.0
google-cloud-env 1.6.0
google-apis-iamcredentials_v1 0.17.0
google-apis-storage_v1 0.31.0
google-cloud-errors 1.3.1
google-cloud-core 1.6.1
google-cloud-storage 1.47.0
json 2.7.1
mini_magick 4.12.0
naturally 2.2.1
optparse 0.4.0
plist 3.7.1
rubyzip 2.3.2
security 0.1.3
simctl 1.6.10
terminal-notifier 2.0.0
unicode-display_width 2.5.0
terminal-table 3.0.2
tty-screen 0.8.2
tty-cursor 0.7.1
tty-spinner 0.9.3
word_wrap 1.0.0
nanaimo 0.3.0
xcodeproj 1.23.0
rouge 2.0.7
xcpretty 0.3.0
xcpretty-travis-formatter 1.0.1

generated on: 2024-01-24

@hekuli
Copy link

hekuli commented May 27, 2024 •
edited

I am seeing the exact same issue with: iPhone 14 Pro, iPhone 15, and iPhone 15 Pro. So none of the devices usable for 6.1" displays work.

  • produced manually: size of 1179x2556
  • produced with fastlane: 1178x2556

This is my bash script to workaround: https://gist.github.com/hekuli/e6d00cf4f2167c7c477b7908b80c4e52

✅ fastlane environment ✅

Stack

Key Value
OS 14.5
Ruby 3.3.1
Bundler? false
Git git version 2.45.1
Installation Source /opt/homebrew/Cellar/fastlane/2.220.0/libexec/bin/fastlane
Host macOS 14.5 (23F79)
Ruby Lib Dir /opt/homebrew/Cellar/ruby/3.3.1/lib
OpenSSL Version OpenSSL 3.3.0 9 Apr 2024
Is contained false
Is homebrew true
Is installed via Fabric.app false
Xcode Path /Applications/Xcode.app/Contents/Developer/
Xcode Version 15.4
Swift Version 5.10

System Locale

Variable Value
LANG en_US.UTF-8 ✅
LC_ALL
LANGUAGE

fastlane files:

`./fastlane/Fastfile` 
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

default_platform(:ios)

platform :ios do
  desc "Generate new localized screenshots"
  lane :screenshots do
    capture_screenshots(scheme: "GatherScreenshots", stop_after_first_error: true)
    frame_screenshots()
    #sh "./postprocess_screenshots.bash"
    #upload_to_app_store(skip_binary_upload: true, skip_metadata: true, skip_screenshots: false, overwrite_screenshots: true)
  end
end
`./fastlane/Appfile` 
app_identifier("XXXXXXXXXXX") # The bundle identifier of your app
apple_id("XXXXXXXX@XXXXXX.com") # Your Apple Developer Portal username

itc_team_id("XXXXXXX") # App Store Connect Team ID
team_id("XXXXXXXX") # Developer Portal Team ID

# For more information about the Appfile, see:
#     https://docs.fastlane.tools/advanced/#appfile

fastlane gems

Gem Version Update-Status
fastlane 2.220.0 ✅ Up-To-Date

Loaded fastlane plugins:

No plugins Loaded

Loaded gems
Gem Version
error_highlight 0.6.0
did_you_mean 1.6.3
syntax_suggest 2.0.0
public_suffix 5.0.5
addressable 2.8.6
artifactory 3.0.17
babosa 1.0.4
bundler 2.5.9
base64 0.2.0
CFPropertyList 3.0.7
colored 1.2
highline 2.0.3
commander 4.6.0
dotenv 2.8.1
emoji_regex 3.2.3
excon 0.110.0
faraday-em_http 1.0.0
faraday-em_synchrony 1.0.0
faraday-excon 1.1.0
faraday-httpclient 1.0.1
faraday-multipart 1.0.4
faraday-net_http 1.0.1
faraday-net_http_persistent 1.2.0
faraday-patron 1.0.0
faraday-rack 1.0.0
faraday-retry 1.0.3
ruby2_keywords 0.0.5
faraday 1.10.3
faraday_middleware 1.2.0
domain_name 0.6.20240107
http-cookie 1.0.5
faraday-cookie_jar 0.0.7
fastimage 2.3.1
gh_inspector 1.1.3
uber 0.1.0
declarative 0.0.20
trailblazer-option 0.1.2
representable 3.2.0
retriable 3.1.2
mini_mime 1.1.5
jwt 2.8.1
multi_json 1.15.0
os 1.1.4
signet 0.19.0
googleauth 1.8.1
httpclient 2.8.3
google-apis-core 0.11.3
google-apis-androidpublisher_v3 0.54.0
google-apis-playcustomapp_v1 0.13.0
google-cloud-env 1.6.0
google-cloud-errors 1.4.0
google-cloud-core 1.7.0
google-apis-iamcredentials_v1 0.17.0
google-apis-storage_v1 0.31.0
digest-crc 0.6.5
google-cloud-storage 1.47.0
mini_magick 4.12.0
naturally 2.2.1
plist 3.7.1
rubyzip 2.3.2
security 0.1.5
simctl 1.6.10
terminal-notifier 2.0.0
unicode-display_width 2.5.0
terminal-table 3.0.2
tty-screen 0.8.2
tty-cursor 0.7.1
tty-spinner 0.9.3
word_wrap 1.0.0
atomos 0.1.3
claide 1.1.0
colored2 3.1.2
nanaimo 0.3.0
xcodeproj 1.24.0
rouge 2.0.7
xcpretty 0.3.0
xcpretty-travis-formatter 1.0.1
set 1.1.0
aws-eventstream 1.3.0
aws-sigv4 1.8.0
aws-partitions 1.934.0
jmespath 1.6.2
aws-sdk-core 3.196.1
aws-sdk-kms 1.82.0
aws-sdk-s3 1.151.0
strscan 3.1.0
rexml 3.2.8
nkf 0.2.0
multipart-post 2.4.1
rake 13.2.1
json 2.7.2
optparse 0.5.0
forwardable 1.3.3
logger 1.6.0
pathname 0.3.0
shellwords 0.2.0
cgi 0.4.1
date 3.3.4
timeout 0.4.1
securerandom 0.3.1
uri 0.13.0
openssl 3.2.0
digest 3.1.1
ipaddr 1.2.6
resolv 0.3.0
time 0.3.0
stringio 3.1.0
open-uri 0.4.1
mutex_m 0.2.0
net-http 0.4.1
net-protocol 0.2.2
english 0.8.0
erb 4.0.3
abbrev 0.1.2
tempfile 0.2.1
delegate 0.3.1
fileutils 1.7.2
tmpdir 0.2.0
singleton 0.2.0
open3 0.2.1
prettyprint 0.2.0
pp 0.5.0
find 0.2.0
ostruct 0.6.0
yaml 0.3.0
psych 5.1.2

generated on: 2024-05-27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@lacostej @whiskey @joejcon1 @EddyLB @rafcortina @hekuli