Remove deprecated attributes from apps requests (#21187)

* Remove prices from ESSENTIAL_INCLUDES closes #21125 * Fix spec * Fix violations * Fix stubs
fastlane · Apr 16, 2023 · f7e0075 · f7e0075
1 parent 0c06ab0
commit f7e0075
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/spaceship/lib/spaceship/connect_api/models/app.rb b/spaceship/lib/spaceship/connect_api/models/app.rb
@@ -54,12 +54,12 @@ module EducationDiscountType
         "contentRightsDeclaration" => "content_rights_declaration",
 
         "appStoreVersions" => "app_store_versions",
+        # This attribute is already deprecated. It will be removed in a future release.
         "prices" => "prices"
       })
 
       ESSENTIAL_INCLUDES = [
-        "appStoreVersions",
-        "prices"
+        "appStoreVersions"
       ].join(",")
 
       def self.type

diff --git a/spaceship/lib/spaceship/tunes/tunes_client.rb b/spaceship/lib/spaceship/tunes/tunes_client.rb
@@ -272,7 +272,7 @@ def applications
       # if it needs to
       #
       # https://github.com/fastlane/fastlane/pull/20480
-      r = request(:get, "https://appstoreconnect.apple.com/iris/v1/apps?include=appStoreVersions,prices")
+      r = request(:get, "https://appstoreconnect.apple.com/iris/v1/apps?include=appStoreVersions")
       response = Spaceship::ConnectAPI::Response.new(
         body: r.body,
         status: r.status,

diff --git a/spaceship/spec/connect_api/testflight/testflight_stubbing.rb b/spaceship/spec/connect_api/testflight/testflight_stubbing.rb
@@ -18,10 +18,10 @@ def stub_apps
         stub_request(:get, "https://appstoreconnect.apple.com/iris/v1/apps").
           to_return(status: 200, body: read_fixture_file('apps.json'), headers: { 'Content-Type' => 'application/json' })
 
-        stub_request(:get, "https://appstoreconnect.apple.com/iris/v1/apps?include=appStoreVersions,prices").
+        stub_request(:get, "https://appstoreconnect.apple.com/iris/v1/apps?include=appStoreVersions").
           to_return(status: 200, body: read_fixture_file('apps.json'), headers: { 'Content-Type' => 'application/json' })
 
-        stub_request(:get, "https://appstoreconnect.apple.com/iris/v1/apps?filter%5BbundleId%5D=com.joshholtz.FastlaneTest&include=appStoreVersions,prices").
+        stub_request(:get, "https://appstoreconnect.apple.com/iris/v1/apps?filter%5BbundleId%5D=com.joshholtz.FastlaneTest&include=appStoreVersions").
           to_return(status: 200, body: read_fixture_file('apps.json'), headers: { 'Content-Type' => 'application/json' })
 
         stub_request(:get, "https://appstoreconnect.apple.com/iris/v1/apps/123456789").