Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Match::Storage docs to reflect latest API changes #1225

Merged
merged 1 commit into from
Nov 11, 2023
Merged

fix Match::Storage docs to reflect latest API changes #1225

merged 1 commit into from
Nov 11, 2023

Conversation

arc-v2
Copy link
Contributor

@arc-v2 arc-v2 commented Nov 9, 2023

Update instructions as Match::Storage changed in
fastlane/fastlane#21018

@arc-v2 arc-v2 changed the title Update other.md for Match::Storage API contract changes Update other.md for Match::Storage API changes Nov 9, 2023
@rogerluan rogerluan mentioned this pull request Nov 11, 2023
Merged
5 tasks
rogerluan
rogerluan approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this to our attention @vivek-dtdl 🙏 and thanks for fixing it right away!

LGTM 💪

@rogerluan rogerluan changed the title Update other.md for Match::Storage API changes fix Match::Storage docs to reflect latest API changes Nov 11, 2023
@rogerluan rogerluan merged commit e94bac4 into fastlane:master Nov 11, 2023
2 checks passed
@arc-v2 arc-v2 deleted the patch-1 branch November 11, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogerluan rogerluan rogerluan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arc-v2 @rogerluan