-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove art-template support #466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes art-template support as part of a refactor that introduces a breaking change. Key changes include:
- Removing art-template from the list of supported engines in index.js.
- Deleting the art-template rendering function and its related configuration.
- Updating documentation and benchmark files to eliminate art-template references.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
File | Description |
---|---|
index.js | Removed art-template from supported engines, its rendering function, and associated config. |
README.md | Removed art-template documentation from the list of supported engines and examples. |
benchmark/fastify-art.js | Deleted the benchmark file targeting art-template support. |
Comments suppressed due to low confidence (2)
index.js:391
- Ensure that removal of art-template support is fully reflected in the test suite to avoid accidental references to a non-existent engine.
async function viewArtTemplate (page, data) {
benchmark/fastify-art.js:1
- Confirm that any benchmark tests for art-template have been removed or updated to prevent failures due to the removed engine support.
'use strict'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this 👌
Cheers @simoneb, just want one more review, considering this is a breaking, then i'll merge and do a release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
closes #463. Breaking change.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct