Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove art-template support #466

Merged
merged 1 commit into from
Mar 18, 2025
Merged

refactor!: remove art-template support #466

merged 1 commit into from
Mar 18, 2025

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Mar 17, 2025

closes #463. Breaking change.

Checklist

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
tonistiigi Tõnis Tiigi
@Fdawgs Fdawgs requested a review from a team March 17, 2025 16:10
@simoneb simoneb requested a review from Copilot March 17, 2025 16:11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes art-template support as part of a refactor that introduces a breaking change. Key changes include:

  • Removing art-template from the list of supported engines in index.js.
  • Deleting the art-template rendering function and its related configuration.
  • Updating documentation and benchmark files to eliminate art-template references.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

File Description
index.js Removed art-template from supported engines, its rendering function, and associated config.
README.md Removed art-template documentation from the list of supported engines and examples.
benchmark/fastify-art.js Deleted the benchmark file targeting art-template support.
Comments suppressed due to low confidence (2)

index.js:391

  • Ensure that removal of art-template support is fully reflected in the test suite to avoid accidental references to a non-existent engine.
async function viewArtTemplate (page, data) {

benchmark/fastify-art.js:1

  • Confirm that any benchmark tests for art-template have been removed or updated to prevent failures due to the removed engine support.
'use strict'
Copy link

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this 👌

@simoneb simoneb changed the title refactor: remove art-template support refactor!: remove art-template support Mar 17, 2025
@Fdawgs Fdawgs requested a review from mcollina March 17, 2025 16:16
@Fdawgs
Copy link
Member Author

Fdawgs commented Mar 17, 2025

Cheers @simoneb, just want one more review, considering this is a breaking, then i'll merge and do a release.

@Fdawgs Fdawgs requested a review from a team March 18, 2025 07:17
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit c3cd865 into main Mar 18, 2025
13 checks passed
@Fdawgs Fdawgs deleted the refactor/art branch March 18, 2025 09:30
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove art-template support
4 participants