Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling req.destroy() after reading the whole payload should not error #247

Merged
merged 1 commit into from Jun 6, 2023
Merged

Calling req.destroy() after reading the whole payload should not error #247

merged 1 commit into from Jun 6, 2023

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Jun 6, 2023 •
edited

This change prevents an unwanted undefined error when using this in combination with fastify-http-proxy: fastify/fastify-http-proxy#305

Checklist

@mcollina
Calling req.destroy() after reading the whole payload should not error
2e12960 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina mentioned this pull request Jun 6, 2023
Closed
ivan-tymoshenko
ivan-tymoshenko approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@ivan-tymoshenko ivan-tymoshenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member Author

mcollina commented Jun 6, 2023 •
edited

The CI failure is an infra error on Windows.

@mcollina mcollina merged commit 8730560 into master Jun 6, 2023
28 of 32 checks passed
@mcollina mcollina deleted the calling-destroy-on-body-does-not-error branch June 6, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-tymoshenko ivan-tymoshenko ivan-tymoshenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcollina @ivan-tymoshenko