Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: migrate to node test runner #690

Merged
merged 7 commits into from
Mar 7, 2025
Merged

test: migrate to node test runner #690

merged 7 commits into from
Mar 7, 2025
+3,283 −9,267

Conversation

ilteoood
Copy link
Contributor

@ilteoood ilteoood commented Mar 3, 2025

Checklist

Sorry, something went wrong.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

simoneb
simoneb reviewed Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd take the chance to migrate to Node's mocks as well instead of sinon

@ilteoood
Copy link
Contributor Author

ilteoood commented Mar 6, 2025

I'd take the chance to migrate to Node's mocks as well instead of sinon

Is it something I can do in another PR?
I would avoid mixing it with this migration, just to be 100% sure that tests after this still works perfectly

simoneb
simoneb reviewed Mar 7, 2025
View reviewed changes
.gitignore Outdated
@@ -3,3 +3,4 @@ node_modules/
.idea
.nyc_output
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this exclusion?

test/mapUpdateType.test.js Outdated
t.equal(mapUpdateType('bad_input'), updateTypes.any)
t.equal(mapUpdateType(), updateTypes.any)
t.equal(mapUpdateType('any'), updateTypes.any)
t.assert.deepStrictEqual(mapUpdateType('major'), updateTypes.major)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the deep part when comparing simple values?

@simoneb
Copy link
Collaborator

simoneb commented Mar 7, 2025

I'd take the chance to migrate to Node's mocks as well instead of sinon

Is it something I can do in another PR? I would avoid mixing it with this migration, just to be 100% sure that tests after this still works perfectly

I'm ok with this, sure 👌

@ilteoood
fix: addressed review comments
Loading
Loading status checks…
4a47860
@ilteoood ilteoood requested a review from simoneb March 7, 2025 11:05
@simoneb simoneb merged commit 731961a into fastify:main Mar 7, 2025
2 of 3 checks passed
@github-actions github-actions bot mentioned this pull request Mar 8, 2025
Closed
@optic-release-automation optic-release-automation bot mentioned this pull request Mar 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ilteoood @simoneb