Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add output with merge status #430

Merged
merged 3 commits into from
May 26, 2023
Merged

feat: add output with merge status #430

merged 3 commits into from
May 26, 2023

Conversation

guilhermelimak
Copy link
Contributor

@guilhermelimak guilhermelimak commented May 26, 2023 •
edited

This PR adds an output variable merge_status containing the merge status so users can run other actions based on the result of the merge.

Closes #323

@simoneb simoneb mentioned this pull request May 26, 2023
Closed
2 tasks
simoneb
simoneb reviewed May 26, 2023
View reviewed changes
Copy link
Collaborator

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thanks for the nice and tidy implementation and testing. I posted an inline comment that I would like you to implement. Thanks

src/action.js Outdated Show resolved Hide resolved
@simoneb simoneb merged commit f7bf859 into fastify:main May 26, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Jun 3, 2023
Closed
@guilhermelimak guilhermelimak deleted the feat/add-status-output branch June 12, 2023 17:48
@optic-release-automation optic-release-automation bot mentioned this pull request Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide merge outcome as output
2 participants
@guilhermelimak @simoneb