Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't return the done function #5937

Merged
merged 2 commits into from
Jan 11, 2025
Merged

chore: don't return the done function #5937

merged 2 commits into from
Jan 11, 2025

Conversation

gurgunday
Copy link
Member

It's a small thing but we're never interested in what done returns and in most of the codebase we use:

done()
return

For brevity, I've updated the remaining parts to also return directly and not return done

@gurgunday gurgunday changed the title chore: explicitly return undefined instead of the done function chore: don't return the done function Jan 10, 2025
@gurgunday gurgunday merged commit 677adbf into main Jan 11, 2025
27 checks passed
@gurgunday gurgunday deleted the consistent-done branch January 11, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants