Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: request route schema might be undefined #5394

Merged
merged 3 commits into from
May 7, 2024
Merged

types: request route schema might be undefined #5394

merged 3 commits into from
May 7, 2024
+4 −4

Conversation

nflaig
Copy link
Contributor

@nflaig nflaig commented Apr 9, 2024 •
edited

Closes #5393 by marking route schema type as optional

Checklist

This was referenced Apr 9, 2024
Closed
Closed
Eomm
Eomm reviewed Apr 9, 2024
View reviewed changes
types/request.d.ts Outdated Show resolved Hide resolved
@nflaig @Eomm
Update types/request.d.ts
6103024 
Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
Signed-off-by: Nico Flaig <nflaig@protonmail.com>
nflaig
nflaig commented Apr 9, 2024
View reviewed changes
types/request.d.ts Outdated Show resolved Hide resolved
types/request.d.ts Outdated Show resolved Hide resolved
@nflaig
Comment why it might be undefined / empty
30e7b12 
Signed-off-by: Nico Flaig <nflaig@protonmail.com>
mcollina
mcollina requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer #5395 to this.

@nflaig
Copy link
Contributor Author

nflaig commented Apr 23, 2024

Closing in favor of #5395

@nflaig nflaig closed this Apr 23, 2024
@nflaig nflaig reopened this May 6, 2024
mcollina
mcollina approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cc @Eomm

@mcollina mcollina merged commit 445e41a into fastify:main May 7, 2024
74 checks passed
@urbankrepel urbankrepel mentioned this pull request May 28, 2024
Merged
@Viorel1989 Viorel1989 mentioned this pull request May 28, 2024
Open
@RanielliMontagna RanielliMontagna mentioned this pull request May 28, 2024
Open
@denbon05 denbon05 mentioned this pull request May 28, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request May 29, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request May 29, 2024
Open
@bryopsida bryopsida mentioned this pull request May 29, 2024
Merged
This was referenced May 30, 2024
Closed
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Jun 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route schema might be undefined
3 participants
@nflaig @mcollina @Eomm