Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve onError docs by specifying what the error handler is #5358

Merged
merged 2 commits into from
Apr 22, 2024
Merged

docs: improve onError docs by specifying what the error handler is #5358

merged 2 commits into from
Apr 22, 2024

Conversation

tmcw
Copy link
Contributor

@tmcw tmcw commented Mar 12, 2024

The docs refer to customErrorHandler but don't say what it is - this links the setErrorHandler method.

Checklist

mcollina
mcollina approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina changed the title Improve onError docs by specifying what the error handler is docs: improve onError docs by specifying what the error handler is Mar 19, 2024
@mcollina
Copy link
Member

Can you please fix the docs linter?

Uzlopak
Uzlopak reviewed Mar 22, 2024
View reviewed changes
docs/Reference/Hooks.md Outdated Show resolved Hide resolved
@Uzlopak
Apply suggestions from code review
caabfa4 
Signed-off-by: Aras Abbasi <aras.abbasi@googlemail.com>
mcollina
mcollina approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

@mcollina mcollina merged commit 6258d8a into fastify:main Apr 22, 2024
5 checks passed
@Treasuremathew1
Copy link

Hi

@urbankrepel urbankrepel mentioned this pull request May 28, 2024
Merged
@Viorel1989 Viorel1989 mentioned this pull request May 28, 2024
Open
@RanielliMontagna RanielliMontagna mentioned this pull request May 28, 2024
Open
@denbon05 denbon05 mentioned this pull request May 28, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request May 29, 2024
Open
@JamieVangeysel JamieVangeysel mentioned this pull request May 29, 2024
Open
@bryopsida bryopsida mentioned this pull request May 29, 2024
Merged
This was referenced May 30, 2024
Closed
Open
@JamieVangeysel JamieVangeysel mentioned this pull request Jun 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak left review comments

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

customErrorHandler is a mystery in the documentation
4 participants
@tmcw @mcollina @Treasuremathew1 @Uzlopak