Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: spelling corrections #5349

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Conversation

10xLaCroixDrinker
Copy link
Contributor

Just fixing some spelling errors through docs, comments & tests

Checklist

@metcoder95 metcoder95 requested a review from Fdawgs March 8, 2024 08:55
Copy link
Member

@Fdawgs Fdawgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will review properly next week.
FYI, Fastify uses American/Simple English over British/Traditional English, so "Behavior" is correct.

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comments (and subsequent lines that are the same but I left uncommented), this looks good. Please resolve the issues highlighted.

docs/Guides/Prototype-Poisoning.md Outdated Show resolved Hide resolved
docs/Reference/Encapsulation.md Outdated Show resolved Hide resolved
docs/Reference/Index.md Outdated Show resolved Hide resolved
docs/Reference/Reply.md Outdated Show resolved Hide resolved
docs/Reference/TypeScript.md Show resolved Hide resolved
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@10xLaCroixDrinker
Copy link
Contributor Author

FYI, Fastify uses American/Simple English over British/Traditional English

Should https://fastify.dev/organisations/ be https://fastify.dev/organizations/ then? Is that a PR you'd be open to (with a redirect of course)?

@jsumners
Copy link
Member

jsumners commented Mar 8, 2024

I'll leave that up to the @fastify/website team. But I don't think we need to be so pedantic as to break the website.

(FYI: I'm American, having never left the country in my 4+ decades [record to be broke in April 🎉], and I routinely write British variants of words before spellcheck kicks in. I'm not a stickler for the variants. We just have a style guide and should adhere to it as much as makes sense for consistency.)

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday
Copy link
Member

FYI, Fastify uses American/Simple English over British/Traditional English

Should https://fastify.dev/organisations/ be https://fastify.dev/organizations/ then? Is that a PR you'd be open to (with a redirect of course)?

I think for consistency sake it should be "organizations", is it hard to add a redirect to "organisations"? Not familiar with what framework the website uses

@10xLaCroixDrinker
Copy link
Contributor Author

@gurgunday the site is built with docusaurus and already uses a plugin for a few other redirects, so it would just take a couple additional lines to that plugin config

@mcollina
Copy link
Member

mcollina commented Mar 9, 2024

let's do it

test/logger/instantiation.test.js Outdated Show resolved Hide resolved
test/skip-reply-send.test.js Outdated Show resolved Hide resolved
10xLaCroixDrinker and others added 2 commits March 10, 2024 15:47
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
Signed-off-by: Jamie King <hello@jamieking.me>
@jsumners jsumners merged commit c957be2 into fastify:main Mar 11, 2024
40 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the docs/spelling branch March 11, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants