(more) small performance/clarity improvements #405

gurgunday · 2023-09-06T15:10:24Z

Changes:

Use for loops for arrays rather than for...of
Use already created variables instead of constantly accessing object properties
Prefer x === undefined over typeof x === 'undefined'
Prefer destructuring
~~Prefer String/Array.prototype.at~~ node 14
Object assign instead of spread
~~||=~~
~~String.replaceAll~~

Before merging, I would also like to move the pumpSendToReply function to the bottom of the plugin scope, next to other functions, because it really makes it harder to follow the execution of the file. I haven't done so now to make reviewing easier

Checklist

run npm run test and npm run benchmark
tests and/or benchmarks are included
documentation is changed or added
commit message and code follows the Developer's Certification of Origin
and the Code of conduct

…into ref

gurgunday · 2023-09-06T15:16:17Z

I’ll take a look at why ci failed

Uzlopak · 2023-09-06T15:50:33Z

@gurgunday
node 14 does not support ??= yet

index.js

gurgunday · 2023-09-06T16:44:44Z

it's .at

gurgunday · 2023-09-06T17:02:08Z

After an approval, I'll simply move the pumpSendToReply function next to where other functions are defined for readability

index.js

Uzlopak

makes some sense. consider my remarks please

Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>

…o ref

Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>

mcollina

lgtm

Uzlopak

LGTM

@gurgunday now you can merge this PR by using Squash merge ;)

mcollina · 2023-09-07T06:57:30Z

@Uzlopak you didn't approve but requested changes.

Uzlopak

D'oh
Hard to merge if i mark it wrong...

Eomm · 2023-09-07T07:16:17Z

LGTM

@gurgunday now you can merge this PR by using Squash merge ;)

I can disable the "merge" button and set the squash&merge the default one.
If you spot repos that have not this configuration, tag me and I will fix it

The configuration has been updated at this repo now 👍🏼

gurgunday · 2023-09-07T07:28:12Z

Yess✨✨ I was going to ask about this to prevent accidents 😁

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/static](https://togithub.com/fastify/fastify-static) | [`6.11.0` -> `6.11.1`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.11.0/6.11.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fstatic/6.11.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fstatic/6.11.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fstatic/6.11.0/6.11.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fstatic/6.11.0/6.11.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-static (@fastify/static)</summary> ### [`v6.11.1`](https://togithub.com/fastify/fastify-static/releases/tag/v6.11.1) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v6.11.0...v6.11.1) ##### What's Changed - Remove test/content-type/sample.jpg.br by [@mcollina](https://togithub.com/mcollina) in [fastify/fastify-static#400 - build(deps-dev): bump tsd from 0.28.1 to 0.29.0 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify-static#401 - added some small code improvements by [@turnerran](https://togithub.com/turnerran) in [fastify/fastify-static#399 - (more) small performance/clarity improvements by [@gurgunday](https://togithub.com/gurgunday) in [fastify/fastify-static#405 - perf: use `node:` prefix to bypass require.cache call for builtins by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-static#407 - use native stream by [@gurgunday](https://togithub.com/gurgunday) in [fastify/fastify-static#408 - Fix request route config deprecation warnings by [@TTPO100AJIEX](https://togithub.com/TTPO100AJIEX) in [fastify/fastify-static#409 ##### New Contributors - [@turnerran](https://togithub.com/turnerran) made their first contribution in [fastify/fastify-static#399 - [@TTPO100AJIEX](https://togithub.com/TTPO100AJIEX) made their first contribution in [fastify/fastify-static#409 **Full Changelog**: fastify/fastify-static@v6.11.0...v6.11.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@fastify/static](https://togithub.com/fastify/fastify-static) | [`6.10.2` -> `6.12.0`](https://renovatebot.com/diffs/npm/@fastify%2fstatic/6.10.2/6.12.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@fastify%2fstatic/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fastify%2fstatic/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fastify%2fstatic/6.10.2/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fastify%2fstatic/6.10.2/6.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastify/fastify-static (@fastify/static)</summary> ### [`v6.12.0`](https://togithub.com/fastify/fastify-static/releases/tag/v6.12.0) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v6.11.2...v6.12.0) #### What's Changed - fix eslint by [@gurgunday](https://togithub.com/gurgunday) in [fastify/fastify-static#415 - refactor: add `u` unicode flag to regex by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-static#418 - refactor: remove unused bindings by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-static#417 - perf(index): check set size over converting to array to check length by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-static#416 - chore(package): explicitly declare js module type by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-static#419 - test: replace `typeof` undefined check by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-static#420 **Full Changelog**: fastify/fastify-static@v6.11.2...v6.12.0 ### [`v6.11.2`](https://togithub.com/fastify/fastify-static/releases/tag/v6.11.2) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v6.11.1...v6.11.2) #### What's Changed - fix: allow fallback to fastify@2.22 route config by [@climba03003](https://togithub.com/climba03003) in [fastify/fastify-static#410 **Full Changelog**: fastify/fastify-static@v6.11.1...v6.11.2 ### [`v6.11.1`](https://togithub.com/fastify/fastify-static/releases/tag/v6.11.1) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v6.11.0...v6.11.1) #### What's Changed - Remove test/content-type/sample.jpg.br by [@mcollina](https://togithub.com/mcollina) in [fastify/fastify-static#400 - build(deps-dev): bump tsd from 0.28.1 to 0.29.0 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify-static#401 - added some small code improvements by [@turnerran](https://togithub.com/turnerran) in [fastify/fastify-static#399 - (more) small performance/clarity improvements by [@gurgunday](https://togithub.com/gurgunday) in [fastify/fastify-static#405 - perf: use `node:` prefix to bypass require.cache call for builtins by [@Fdawgs](https://togithub.com/Fdawgs) in [fastify/fastify-static#407 - use native stream by [@gurgunday](https://togithub.com/gurgunday) in [fastify/fastify-static#408 - Fix request route config deprecation warnings by [@TTPO100AJIEX](https://togithub.com/TTPO100AJIEX) in [fastify/fastify-static#409 #### New Contributors - [@turnerran](https://togithub.com/turnerran) made their first contribution in [fastify/fastify-static#399 - [@TTPO100AJIEX](https://togithub.com/TTPO100AJIEX) made their first contribution in [fastify/fastify-static#409 **Full Changelog**: fastify/fastify-static@v6.11.0...v6.11.1 ### [`v6.11.0`](https://togithub.com/fastify/fastify-static/releases/tag/v6.11.0) [Compare Source](https://togithub.com/fastify/fastify-static/compare/v6.10.2...v6.11.0) #### What's Changed - Update README with 404+wildcard behavior by [@Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) in [fastify/fastify-static#390 - add tests for [#234](https://togithub.com/fastify/fastify-static/issues/234) by [@gurgunday](https://togithub.com/gurgunday) in [fastify/fastify-static#391 - remove linting from the test script by [@gurgunday](https://togithub.com/gurgunday) in [fastify/fastify-static#394 - Remove redundant parameter by [@gurgunday](https://togithub.com/gurgunday) in [fastify/fastify-static#395 - build(deps-dev): bump [@typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) from 2.34.0 to 6.2.1 by [@dependabot](https://togithub.com/dependabot) in [fastify/fastify-static#397 - add url type by [@gurgunday](https://togithub.com/gurgunday) in [fastify/fastify-static#398 #### New Contributors - [@Ethan-Arrowood](https://togithub.com/Ethan-Arrowood) made their first contribution in [fastify/fastify-static#390 - [@gurgunday](https://togithub.com/gurgunday) made their first contribution in [fastify/fastify-static#391 **Full Changelog**: fastify/fastify-static@v6.10.2...v6.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/specfy/specfy).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

gurgunday added 9 commits September 6, 2023 16:07

use destructuring

89d0a87

don't use typeof === 'undef'

c8677be

remove errorHandler

d15c411

use for loops

7870cac

use parsedPathname

4002595

use .at

f9ed0d8

use already declared var

f9616de

use ??=

c9436c5

Merge branch 'master' of https://github.com/gurgunday/fastify-static …

9114f8b

…into ref

Uzlopak reviewed Sep 6, 2023

View reviewed changes

index.js Outdated Show resolved Hide resolved

Uzlopak reviewed Sep 6, 2023

View reviewed changes

index.js Outdated Show resolved Hide resolved

gurgunday added 3 commits September 6, 2023 18:23

don't use ??=

5e5439c

extract regex

be04f52

typo

aa9b53a

gurgunday added 2 commits September 6, 2023 18:46

remove .at

2769b2c

revert hardcoded seperators

04e2690

Uzlopak reviewed Sep 6, 2023

View reviewed changes

index.js Outdated Show resolved Hide resolved

Uzlopak reviewed Sep 6, 2023

View reviewed changes

index.js Outdated Show resolved Hide resolved

Uzlopak reviewed Sep 6, 2023

View reviewed changes

index.js Outdated Show resolved Hide resolved

Uzlopak reviewed Sep 6, 2023

View reviewed changes

index.js Outdated Show resolved Hide resolved

Uzlopak reviewed Sep 6, 2023

View reviewed changes

gurgunday and others added 5 commits September 6, 2023 20:27

add spacing

fff05de

Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>

move comment

b684347

Merge branch 'ref' of https://github.com/gurgunday/fastify-static int…

63587e5

…o ref

extract regex

af613b1

use object assign instead of spread syntax

05d9a01

simplify prefix assignment

acf0221

Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>

mcollina approved these changes Sep 6, 2023

View reviewed changes

move pumpSendToReply to the bottom

082576c

gurgunday requested a review from Uzlopak September 6, 2023 20:06

gurgunday mentioned this pull request Sep 6, 2023

Upgrade glob to v10 #406

Merged

4 tasks

Uzlopak requested changes Sep 7, 2023

View reviewed changes

Uzlopak approved these changes Sep 7, 2023

View reviewed changes

gurgunday merged commit b923bef into fastify:master Sep 7, 2023
15 checks passed

gurgunday deleted the ref branch September 7, 2023 07:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(more) small performance/clarity improvements #405

(more) small performance/clarity improvements #405

gurgunday commented Sep 6, 2023 •

edited

gurgunday commented Sep 6, 2023

Uzlopak commented Sep 6, 2023

gurgunday commented Sep 6, 2023

gurgunday commented Sep 6, 2023 •

edited

Uzlopak left a comment

mcollina left a comment

Uzlopak left a comment

mcollina commented Sep 7, 2023

Uzlopak left a comment

Eomm commented Sep 7, 2023

gurgunday commented Sep 7, 2023

(more) small performance/clarity improvements #405

(more) small performance/clarity improvements #405

Conversation

gurgunday commented Sep 6, 2023 • edited

Checklist

gurgunday commented Sep 6, 2023

Uzlopak commented Sep 6, 2023

gurgunday commented Sep 6, 2023

gurgunday commented Sep 6, 2023 • edited

Uzlopak left a comment

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

Uzlopak left a comment

Choose a reason for hiding this comment

mcollina commented Sep 7, 2023

Uzlopak left a comment

Choose a reason for hiding this comment

Eomm commented Sep 7, 2023

gurgunday commented Sep 7, 2023

gurgunday commented Sep 6, 2023 •

edited

gurgunday commented Sep 6, 2023 •

edited