- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
🌐 Add Ukrainian translation for docs/uk/docs/tutorial/query-params.md
#13362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Ukrainian translation for docs/uk/docs/tutorial/query-params.md
#13362
Conversation
📝 Docs preview for commit a9e6b82 at: https://5cc428c7.fastapitiangolo.pages.dev Modified Pages |
docs/uk/docs/tutorial/query-params.md
Hi @SofiiaTrufanova and @DianaTrufanova, thanks for reviewing these translation PRs! It would be helpful if you could add a bit of context on what exactly you reviewed, whether you are a native UK speaker or not, and whether or not you checked that all the content on the English page is accurately reflected in this translation. Just a quick "approved" unfortunately does not tell us much about the way you've reviewed, and generally it would also suprise me if there are always zero review comments (feel free to nitpick a bit!). |
Hi! @svlandeg I reviewed the translation from the English version to Ukrainian cause I'm a native speaker of Ukrainian and all is fine in that translation and nothing needs to be added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a formatting nitpick 😅
Hi @svlandeg, |
📝 Docs preview for commit bf8614b at: https://8a02283c.fastapitiangolo.pages.dev Modified Pages |
@valentinDruzhinin great work (as in all other PRs) Could you pls replace all |
Co-authored-by: Alejandra <90076947+alejsdev@users.noreply.github.com>
bf8614b
to
bbde217
Compare
📝 Docs preview for commit bbde217 at: https://47e3782c.fastapitiangolo.pages.dev Modified Pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good from a structural point of view! 🥳
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
📝 Docs preview for commit 0b6d5a7 at: https://0700292a.fastapitiangolo.pages.dev Modified Pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you @valentinDruzhinin! 🍪
And thanks for the help and reviews @svlandeg, @alejsdev, @rostik1410, @SofiiaTrufanova, @DianaTrufanova ☕
No description provided.