Skip to content

🌐 Add Ukrainian translation for docs/uk/docs/tutorial/query-params.md #13362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 28, 2025

Conversation

valentinDruzhinin
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the lang-all Translations label Feb 12, 2025
Copy link
Contributor

@svlandeg svlandeg changed the title Add ukrainian translation for query-params 🌐 Add Ukrainian translation for docs/uk/docs/tutorial/query-params.md Feb 18, 2025
@svlandeg
Copy link
Member

Hi @SofiiaTrufanova and @DianaTrufanova,

thanks for reviewing these translation PRs! It would be helpful if you could add a bit of context on what exactly you reviewed, whether you are a native UK speaker or not, and whether or not you checked that all the content on the English page is accurately reflected in this translation. Just a quick "approved" unfortunately does not tell us much about the way you've reviewed, and generally it would also suprise me if there are always zero review comments (feel free to nitpick a bit!).

@SofiiaTrufanova
Copy link

Hi! @svlandeg I reviewed the translation from the English version to Ukrainian cause I'm a native speaker of Ukrainian and all is fine in that translation and nothing needs to be added

Copy link
Member

@alejsdev alejsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a formatting nitpick 😅

@DianaTrufanova
Copy link

Hi @svlandeg,
I'm a native Ukrainian speaker and after reviewing the translation everything is correct for me. All the content is accurately translated from English to Ukrainian.

Copy link
Contributor

@rostik1410
Copy link
Contributor

@valentinDruzhinin great work (as in all other PRs) Could you pls replace all ви and other forms of this word with Ви. I will not request changes here because this PR already has 2 approvs and those changes are not critical. But would we cool

Valentyn Druzhynin and others added 3 commits February 18, 2025 17:03
Co-authored-by: Alejandra <90076947+alejsdev@users.noreply.github.com>
@valentinDruzhinin valentinDruzhinin force-pushed the translate-uk/query-params branch from bf8614b to bbde217 Compare February 18, 2025 22:06
Copy link
Contributor

Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good from a structural point of view! 🥳

valentinDruzhinin and others added 2 commits February 24, 2025 18:17
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
Copy link
Contributor

Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you @valentinDruzhinin! 🍪

And thanks for the help and reviews @svlandeg, @alejsdev, @rostik1410, @SofiiaTrufanova, @DianaTrufanova

@tiangolo tiangolo merged commit 23821e9 into fastapi:master Feb 28, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-uk Ukrainian translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants