Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese for Games Touhou #2829

Merged

Conversation

shiroemons
Copy link
Contributor

Motivation / Background

This Pull Request has been created because there was no Japanese support for Games Touhou.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shiroemons thank you for your contribution! Could you limit the number of lines in the file? It's really large. We don't need to include everything, maybe just 50 would be a good maximum limit?

Thank you!

@shiroemons
Copy link
Contributor Author

Hi, @stefannibrasil thank you for the feedback! While I couldn't reduce the file to 50 lines, I've managed to trim it down by about 80%. I hope this makes it more manageable.

@stefannibrasil
Copy link
Contributor

Thank you @shiroemons yes, that is so much more manageable.

One final thing- I translated them and there are some words that I wanted to ask to be removed: "murder", "bullet". I understand they are part of the game vocabulary but I want to avoid merging words that can instigate/mention violence. thank you!

@shiroemons shiroemons force-pushed the add-japanese-for-games-touhou branch from efa943b to 79b2193 Compare October 3, 2023 14:53
@shiroemons
Copy link
Contributor Author

Thank you for your feedback!

The terms "murder" and "bullet" have been removed from the codebase. Could you please confirm if there are any other instances where the term "bullet" is translated?

Thank you!

Copy link
Contributor

@stefannibrasil stefannibrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thank you @shiroemons 🇯🇵

@stefannibrasil stefannibrasil merged commit ea21d56 into faker-ruby:main Oct 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants