Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add danish country code #2818

Merged
merged 3 commits into from Sep 7, 2023
Merged

feat: add danish country code #2818

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb1d2bc
feat: add danish country code
hoshy Aug 29, 2023
520f812
test: add tests for da_dk country_code
hoshy Sep 6, 2023
02f875e
refactor: country_code should be an array to keep the pattern
hoshy Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/locales/da-DK.yml
View file
Open in desktop
Expand Up @@ -52,6 +52,8 @@ da-DK:
- "#{first_name} #{last_name} #{last_name}"
- "#{first_name} #{last_name} #{last_name}"

country_code: '45'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
country_code: '45'
country_code: ['45']

Did this work for you as it is? Looking at the other locales, it seems the generator expects this value to be in an array 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working with the sting. See 520f812

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, thank you for confirming! Do you mind adding an array just to keep the pattern? If in the future we refactor these files, it's easier if they all follow the same pattern. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, see 02f875e

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!


phone_number:
formats:
- '## ## ## ##'
Expand Down