-
-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra(commit-and-tag-version): auto-bump version in usage-guide #3250
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Cool that you found this, but could you guide me towards documentation on the "scripts" property? I cannot seem to find any references towards that in their documentation. 🤔 |
Its part of the commit and tag version plugin config: I'm not sure why there are two different documentations and I consider this one hard to read/understand. You can try the script in a linux docker container.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3250 +/- ##
==========================================
- Coverage 99.96% 99.95% -0.01%
==========================================
Files 2806 2806
Lines 217144 217144
Branches 974 971 -3
==========================================
- Hits 217062 217042 -20
- Misses 82 102 +20 |
Automates another step from the release process:
Preview
Limitations
Doesn't seem to work on windows maybe because it launches a new CMD instead of (git-)bash
(I don't expect us to do releases locally again though)
Alternatives Considered
I also considered using a js script for the replacing, but that requires converting the
.versionrc.json
to.versionrc.js
.It might be possible to use a ts file instead, if we tsc "compile" it before delegating to commit-and-tag-version in
pnpm run release
.