Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update actions/checkout digest to 1e31de5 #2498

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 23, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
actions/checkout action digest 3df4ab1 -> 1e31de5

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner October 23, 2023 00:27
@renovate renovate bot added the c: dependencies Pull requests that adds/updates a dependency label Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #2498 (975caca) into next (b083836) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2498   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files        2823     2823           
  Lines      255520   255520           
  Branches     1099     1104    +5     
=======================================
+ Hits       254459   254470   +11     
+ Misses       1033     1022   -11     
  Partials       28       28           

see 2 files with indirect coverage changes

@matthewmayer
Copy link
Contributor

Bit suspicious. Why should the hash change if the version hasn't? I thought the point of #2208 was to pin the dependencies so a specific version would be linked with a fixed hash?

ST-DDT
ST-DDT previously approved these changes Oct 23, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Oct 23, 2023

4.1.1 has been released. I think the versions comment didnt get updated though.

@ST-DDT
Copy link
Member

ST-DDT commented Oct 23, 2023

Mhh they re-released v4.0.0.
https://github.com/actions/checkout/releases/tag/v4.0.0

@renovate renovate bot force-pushed the renovate/actions-checkout-digest branch from 2d06914 to fab87bb Compare October 23, 2023 06:30
@ST-DDT ST-DDT dismissed their stale review October 23, 2023 06:36

reconsidering

@renovate renovate bot force-pushed the renovate/actions-checkout-digest branch from fab87bb to 2598f8d Compare October 23, 2023 06:52
@ST-DDT
Copy link
Member

ST-DDT commented Oct 23, 2023

They changed the release to update the readme.
actions/checkout@1e31de5

@ST-DDT ST-DDT added this to the vAnytime milestone Oct 23, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Oct 23, 2023

For some reason renovate did not update to the latest version instead it kept the version in the comment.

@renovate renovate bot force-pushed the renovate/actions-checkout-digest branch from 2598f8d to f92aaf4 Compare October 23, 2023 08:55
@ST-DDT ST-DDT requested review from a team October 23, 2023 09:00
@renovate renovate bot force-pushed the renovate/actions-checkout-digest branch from f92aaf4 to d88042a Compare October 23, 2023 10:22
@ST-DDT
Copy link
Member

ST-DDT commented Oct 23, 2023

For some reason renovate did not update to the latest version instead it kept the version in the comment.

Because there is already a different PR for that:

@renovate renovate bot force-pushed the renovate/actions-checkout-digest branch from d88042a to 975caca Compare October 23, 2023 12:33
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit SAH checks out - related file changes look fine for me.

@ST-DDT ST-DDT merged commit c970ca0 into next Oct 23, 2023
20 checks passed
@ST-DDT ST-DDT deleted the renovate/actions-checkout-digest branch October 23, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: dependencies Pull requests that adds/updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants