Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: how to use with Playwright #2489

Merged
merged 4 commits into from
Nov 3, 2023
Merged

docs: how to use with Playwright #2489

merged 4 commits into from
Nov 3, 2023

Conversation

jfgreffier
Copy link
Contributor

Playwright is a popular end-to-end testing solution. The tests are somewhat similar to Jest, but not exactly so here is an example of Faker integration into a Playwright test.

@jfgreffier jfgreffier requested a review from a team October 21, 2023 09:49
@jfgreffier jfgreffier requested a review from a team as a code owner October 21, 2023 09:49
@Shinigami92
Copy link
Member

@debs-obrien Does this meet your requirements? Or should we improve something, such as a way of style like Playwright should best be used?

@xDivisionByZerox xDivisionByZerox added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Oct 21, 2023
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #2489 (bcbe3a6) into next (18bbc3a) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2489      +/-   ##
==========================================
- Coverage   99.59%   99.59%   -0.01%     
==========================================
  Files        2823     2823              
  Lines      255507   255507              
  Branches     1105     1105              
==========================================
- Hits       254470   254468       -2     
- Misses       1009     1011       +2     
  Partials       28       28              

see 1 file with indirect coverage changes

docs/guide/frameworks.md Outdated Show resolved Hide resolved
docs/guide/frameworks.md Outdated Show resolved Hide resolved
@xDivisionByZerox
Copy link
Member

There is a formatting error. Please run the formatter locally via pnpm run format.


Thank you for your contribution ❤️

@ST-DDT
Copy link
Member

ST-DDT commented Oct 22, 2023

FFR: Please avoid force pushing as it makes incremental reviews harder.

docs/guide/frameworks.md Outdated Show resolved Hide resolved
docs/guide/frameworks.md Show resolved Hide resolved
jfgreffier and others added 2 commits November 1, 2023 14:41
Co-authored-by: DivisionByZero <leyla.jaehnig@gmx.de>
@ST-DDT ST-DDT requested review from a team November 2, 2023 17:27
@ST-DDT ST-DDT merged commit 0ad88a6 into faker-js:next Nov 3, 2023
20 checks passed
@ST-DDT
Copy link
Member

ST-DDT commented Nov 3, 2023

Thanks for your contribution. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants