Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(unicorn): consistent-destructuring #2462

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 10, 2023

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Oct 10, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 10, 2023
@ST-DDT ST-DDT requested review from a team October 10, 2023 08:51
@ST-DDT ST-DDT self-assigned this Oct 10, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 10, 2023

The current unique method implementation is bad... we should un-recursive it and cleanup the options in v9.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #2462 (821f4b6) into next (5395074) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2462      +/-   ##
==========================================
- Coverage   99.59%   99.58%   -0.01%     
==========================================
  Files        2823     2823              
  Lines      255518   255516       -2     
  Branches     1104     1101       -3     
==========================================
- Hits       254479   254462      -17     
- Misses       1011     1026      +15     
  Partials       28       28              
Files Coverage Δ
src/modules/helpers/unique.ts 98.68% <100.00%> (-0.02%) ⬇️

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT enabled auto-merge (squash) October 11, 2023 18:45
@ST-DDT ST-DDT merged commit 28d3bad into next Oct 11, 2023
20 checks passed
@ST-DDT ST-DDT deleted the infra/unicorn/consistent-destructuring branch October 11, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants