Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: enable no-useless-escape eslint rule #2434

Merged
merged 7 commits into from
Oct 7, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 5, 2023

This lint rule is likely to be enabled/"covered" by eslint rule unicorn/better-regex after #2418 is merged.

This PR is independent of that PR though.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Oct 5, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 5, 2023
@ST-DDT ST-DDT requested review from a team October 5, 2023 20:09
@ST-DDT ST-DDT self-assigned this Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #2434 (0e44f6f) into next (c80c035) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2434   +/-   ##
=======================================
  Coverage   99.57%   99.58%           
=======================================
  Files        2823     2823           
  Lines      255523   255523           
  Branches     1098     1103    +5     
=======================================
+ Hits       254449   254468   +19     
+ Misses       1046     1027   -19     
  Partials       28       28           
Files Coverage Δ
src/modules/git/index.ts 100.00% <100.00%> (ø)
src/modules/helpers/index.ts 99.12% <100.00%> (ø)
src/modules/internet/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is acutally pretty cool. I always forget which characters to escape and default to simply ascaping all symbols. This lets me know while coding without having to look it up additionally. I like that.

@ST-DDT ST-DDT enabled auto-merge (squash) October 7, 2023 08:59
@ST-DDT ST-DDT merged commit eb2b18b into next Oct 7, 2023
20 checks passed
@ST-DDT ST-DDT deleted the chore/eslint/enable-no-useless-escape branch October 7, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants